From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.linux.debian.devel.bugs.general,gmane.emacs.devel Subject: Bug#1021842: Finalizing 'inhibit-automatic-native-compilation' Date: Mon, 20 Feb 2023 09:18:02 +0000 Message-ID: References: <20230218.061335.1468428093197134401.tats%nobody@tats.iris.ne.jp> <166586215062.368699.18398270685158383578.reportbug@convex> Reply-To: Andrea Corallo , 1021842@bugs.debian.org Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17577"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Tatsuya Kinoshita , emacs-devel@gnu.org, spwhitton@spwhitton.name, 1021842@bugs.debian.org, Eli Zaretskii To: Stefan Monnier Original-X-From: bounce-debian-bugs-dist=glddb-debian-bugs-dist2=m.gmane-mx.org@lists.debian.org Mon Feb 20 10:21:10 2023 Return-path: Envelope-to: glddb-debian-bugs-dist2@m.gmane-mx.org Original-Received: from bendel.debian.org ([82.195.75.100]) by ciao.gmane.io with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pU2M9-0004MJ-R2 for glddb-debian-bugs-dist2@m.gmane-mx.org; Mon, 20 Feb 2023 10:21:09 +0100 Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with QMQP id 4C1C921369; Mon, 20 Feb 2023 09:21:09 +0000 (UTC) X-Mailbox-Line: From debian-bugs-dist-request@lists.debian.org Mon Feb 20 09:21:09 2023 Old-Return-Path: Original-Received: from localhost (localhost [127.0.0.1]) by bendel.debian.org (Postfix) with ESMTP id F1BE621331 for ; Mon, 20 Feb 2023 09:21:08 +0000 (UTC) X-Virus-Scanned: at lists.debian.org with policy bank bug Original-Received: from bendel.debian.org ([127.0.0.1]) by localhost (lists.debian.org [127.0.0.1]) (amavisd-new, port 2525) with ESMTP id qxXwhCr4ChA3 for ; Mon, 20 Feb 2023 09:21:06 +0000 (UTC) Original-Received: from buxtehude.debian.org (buxtehude.debian.org [IPv6:2607:f8f0:614:1::1274:39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "buxtehude.debian.org", Issuer "Debian SMTP CA" (not verified)) by bendel.debian.org (Postfix) with ESMTPS id 40AED20DB3; Mon, 20 Feb 2023 09:21:06 +0000 (UTC) Original-Received: from debbugs by buxtehude.debian.org with local (Exim 4.94.2) (envelope-from ) id 1pU2M2-007EqI-V0; Mon, 20 Feb 2023 09:21:02 +0000 X-Loop: owner@bugs.debian.org Resent-From: Andrea Corallo Resent-To: debian-bugs-dist@lists.debian.org Resent-CC: Rob Browning X-Loop: owner@bugs.debian.org Resent-Date: Mon, 20 Feb 2023 09:21:01 +0000 Resent-Message-ID: X-Debian-PR-Message: followup 1021842 X-Debian-PR-Package: emacsen-common X-Debian-PR-Source: emacsen-common Original-Received: via spool by 1021842-submit@bugs.debian.org id=B1021842.16768846861723570 (code B ref 1021842); Mon, 20 Feb 2023 09:21:01 +0000 Original-Received: (at 1021842) by bugs.debian.org; 20 Feb 2023 09:18:06 +0000 Original-Received: from ma.sdf.org ([205.166.94.33]:49940) by buxtehude.debian.org with esmtps (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.94.2) (envelope-from ) id 1pU2JB-007EN4-9X for 1021842@bugs.debian.org; Mon, 20 Feb 2023 09:18:06 +0000 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1pU2J8-0006Fa-4s; Mon, 20 Feb 2023 09:18:02 +0000 In-Reply-To: (Andrea Corallo's message of "Mon, 20 Feb 2023 09:03:34 +0000") X-Debian-Message: from BTS X-Mailing-List: archive/latest/1761068 X-Loop: debian-bugs-dist@lists.debian.org List-Id: List-URL: List-Post: List-Help: List-Subscribe: List-Unsubscribe: Precedence: list Resent-Sender: debian-bugs-dist-request@lists.debian.org Xref: news.gmane.io gmane.linux.debian.devel.bugs.general:1838712 gmane.emacs.devel:303600 Archived-At: Andrea Corallo writes: > Stefan Monnier writes: > >>> Shouldn't make-temp-file-internal return a non predictable file name? >> >> Nope. It's less predictable but it's still predictable. >> >>> Otherwise what's the point of using make-temp-file in the first place if >>> the temporary name is predictable? >> >> `make-temp-name` uses `O_EXCL | O_CREAT` so as to close the race >> condition: if someone predicated the filename, we detect it atomically >> and we try again. >> >> You might like to check >> >> https://wiki.sei.cmu.edu/confluence/display/c/FIO21-C.+Do+not+create+temporary+files+in+shared+directories > > Thanks for the pointer. > > I'm still not really convinced we have a problem here with trampolines. > With `make-temp-file' we are really only choosing the filename and > suggesting it to libgccjit, this last one will perform the file > creation. I'd be surprised if GCC does not handle this correctly, and > in case shouldn't this be a GCC bug? > > OTOH on a slightly differnt subject and in light of this, I think we > should probably backport e6043641d30 into emacs-30, so that eln files > are created onace and only by libgccjit. Eli WDYT? And BTW, probably also in emacs-28 if we are doing another release. Andrea