From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: master 52b67740d10: Generalise a LAP optimisation rule Date: Tue, 04 Apr 2023 08:10:20 +0000 Message-ID: References: <167976134206.19776.1825822435181145052@vcs2.savannah.gnu.org> <20230325162222.64223C1391B@vcs2.savannah.gnu.org> <86ttxw3ltj.fsf@phe.ftfl.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12144"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org, Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , emacs@FreeBSD.org To: Joseph Mingrone Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 04 10:11:59 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pjbln-0002yZ-E1 for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Apr 2023 10:11:59 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pjbkX-0005oW-OJ; Tue, 04 Apr 2023 04:10:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjbkU-0005mj-LV for emacs-devel@gnu.org; Tue, 04 Apr 2023 04:10:39 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjbkS-0000dc-JO for emacs-devel@gnu.org; Tue, 04 Apr 2023 04:10:38 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.16.1/8.14.5) with ESMTPS id 3348AJ1T009808 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 4 Apr 2023 08:10:19 GMT In-Reply-To: <86ttxw3ltj.fsf@phe.ftfl.ca> (Joseph Mingrone's message of "Mon, 03 Apr 2023 14:41:28 -0300") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: 14 X-Spam_score: 1.4 X-Spam_bar: + X-Spam_report: (1.4 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_SBL_CSS=3.335, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:305094 Archived-At: Joseph Mingrone writes: > On Sat, 2023-03-25 at 12:22, Mattias Engdeg=C3=83=C2=A5rd wrote: > >> branch: master >> commit 52b67740d10df8ca539fdc2c7d50283997683141 >> Author: Mattias Engdeg=C3=A5rd >> Commit: Mattias Engdeg=C3=A5rd > >> Generalise a LAP optimisation rule > >> * lisp/emacs-lisp/byte-opt.el (byte-optimize-lapcode): >> Accept (stack-set 1) as equivalent to (discardN-preserve-tos 1) in a >> rule previously overlooked. This is usually beneficial in code size >> and almost always shortens dynamic paths. >> --- >> lisp/emacs-lisp/byte-opt.el | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) > >> diff --git a/lisp/emacs-lisp/byte-opt.el b/lisp/emacs-lisp/byte-opt.el >> index 3c7aeb89525..0891ec80beb 100644 >> --- a/lisp/emacs-lisp/byte-opt.el >> +++ b/lisp/emacs-lisp/byte-opt.el >> @@ -2765,7 +2765,9 @@ If FOR-EFFECT is non-nil, the return value is assu= med to be of no importance." >> (or (memq (caar tmp) '(byte-discard byte-discardN= )) >> ;; Make sure we don't hoist a discardN-preser= ve-tos >> ;; that really should be merged or deleted in= stead. >> - (and (eq (caar tmp) 'byte-discardN-preserve-t= os) >> + (and (or (eq (caar tmp) 'byte-discardN-preser= ve-tos) >> + (and (eq (caar tmp) 'byte-stack-set) >> + (eql (cdar tmp) 1))) >> (let ((next (cadr tmp))) >> (not (or (memq (car next) >> '(byte-discardN-preserv= e-tos > > Hello, > > This commit causes native compilation builds on FreeBSD to fail with the = error > > native-ice ("org/org-plot.el" "block does not end with a branch"... > > The full error is below and a link to a complete build log (FreeBSD > package build) is also included. > > When the commit is reverted, the build finishes successfully again. > > Joe Hi Joe, thanks for reporting, yes we are tracking this as bug#62537. Best Regards Andrea