unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: Building a release tarball generates trampoline files in eln-cache
Date: Sat, 13 Nov 2021 20:33:39 +0000	[thread overview]
Message-ID: <xjfk0hb6bj0.fsf@ma.sdf.org> (raw)
In-Reply-To: <83ee7kxgd5.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Nov 2021 16:47:02 +0200")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
>> Date: Thu, 11 Nov 2021 21:01:37 +0000
>> 
>> > Would the code to implement this be complicated?  If not, please show
>> > the code you had in mind, so I could make sure we are on the same
>> > page.
>> 
>> I'm attaching the following patch.  It is very much untested but should
>> clarify what I had in mind.
>
> Thanks.  I think we should do this on master, but on the release
> branch compile gv.el AOT, as that will be safer.  WDYT?

I think is sensible.  I'll prepare and test this for master then.

>> > And while I have your attention, another question: suppose that Emacs
>> > with all the preloaded files compiled to *.eln is installed on a
>> > system that has libgccjit (which AFAIU is necessary to run the
>> > native-compiled code), but doesn't have Binutils -- what will happen
>> > when Emacs loads some .el file and tries to compile it?  Will the
>> > response to the compilation failure be graceful?  (This situation is
>> > likely to happen when users install a binary distro, but don't have
>> > Binutils available.)
>> 
>> I believe binutils is a dependecy of libgccjit, so I guess having
>> libgccjit without binutils should be classified as missconfiguration no?
>
> Dependency in what way?  maybe if one installs from a Linux distro,
> Binutils will be installed as a dependency.

Yes this was the scenarion I was thinking of.

> But if someone downloads
> a precompiled libgccjit DLL on Windows, for example, they will not
> have Binutils unless they also install it.  Because libgccjit is part
> of GCC, and one can AFAIK install MinGW GCC without installing
> Binutils.

Interesting, I didn't know it was a realistic scenarion.

Anyway this was never tested by me but... what should happen is that we
signal and error in `comp--compile-ctxt-to-file'.  For async compilation
this should be eventually reported in the async log buffer.

Best Regards

  Andrea



  reply	other threads:[~2021-11-13 20:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-09  8:19 Building a release tarball generates trampoline files in eln-cache Eli Zaretskii
2021-10-09 14:37 ` Ken Brown
2021-10-09 15:05   ` Eli Zaretskii
2021-10-09 15:39     ` Ken Brown
2021-10-09 17:33       ` Ken Brown
2021-10-09 17:51         ` Eli Zaretskii
2021-10-13 19:37           ` Andrea Corallo via Emacs development discussions.
2021-10-14  6:18             ` Eli Zaretskii
2021-10-15  7:35               ` Andrea Corallo via Emacs development discussions.
2021-10-15 18:08                 ` Ken Brown
2021-10-16  8:34                 ` Eli Zaretskii
2021-10-16  9:04                   ` Andrea Corallo
2021-10-16  9:30                     ` Eli Zaretskii
2021-10-16  9:55                       ` Eli Zaretskii
2021-10-16 13:42                         ` Ken Brown
2021-10-16 20:15                         ` Andrea Corallo
2021-10-17  5:56                           ` Eli Zaretskii
2021-10-18 20:46                             ` Andrea Corallo
2021-10-27 16:32                             ` Eli Zaretskii
2021-11-02 18:45                               ` Eli Zaretskii
2021-11-02 19:22                                 ` Andrea Corallo
2021-11-02 19:44                                   ` Stefan Monnier
2021-11-02 19:47                                   ` Eli Zaretskii
2021-11-02 19:51                                     ` Andrea Corallo
2021-11-02 20:26                                     ` Stefan Monnier
2021-11-04 11:12                                       ` Eli Zaretskii
2021-11-05 15:39                                         ` Andrea Corallo
2021-11-05 15:49                                           ` Andrea Corallo
2021-11-08 15:07                                             ` Eli Zaretskii
2021-11-09 21:55                                               ` Andrea Corallo
2021-11-10 18:37                                                 ` Eli Zaretskii
2021-11-11 15:08                                                   ` Andrea Corallo
2021-11-11 16:50                                                     ` Eli Zaretskii
2021-11-11 21:01                                                       ` Andrea Corallo
2021-11-13 14:47                                                         ` Eli Zaretskii
2021-11-13 20:33                                                           ` Andrea Corallo [this message]
2021-11-15 17:34                                                             ` Eli Zaretskii
2021-11-15 19:37                                                               ` Andrea Corallo
2021-11-02 19:49                                   ` Andrea Corallo
2021-11-02 20:09                                     ` Andrea Corallo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjfk0hb6bj0.fsf@ma.sdf.org \
    --to=akrl@sdf.org \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).