From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: --with-native-compilation build failure on 32-bit systems Date: Tue, 09 Aug 2022 09:21:11 +0000 Message-ID: References: <86k07nl9qe.fsf@phe.ftfl.ca> <87bksyc36k.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15303"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Joseph Mingrone , emacs-devel@gnu.org, emacs@FreeBSD.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Aug 09 11:22:36 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLLRb-0003pJ-LW for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Aug 2022 11:22:35 +0200 Original-Received: from localhost ([::1]:34712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLLRa-0002AF-CT for ged-emacs-devel@m.gmane-mx.org; Tue, 09 Aug 2022 05:22:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37628) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLLQL-00015j-83 for emacs-devel@gnu.org; Tue, 09 Aug 2022 05:21:20 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:53948) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLLQJ-0007k0-Cq for emacs-devel@gnu.org; Tue, 09 Aug 2022 05:21:17 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 2799LBlF005561 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 9 Aug 2022 09:21:11 GMT In-Reply-To: (Andrea Corallo's message of "Tue, 09 Aug 2022 09:11:00 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:293291 Archived-At: Andrea Corallo writes: [...] > Just had some time to look into this further: > > Of all the CUs we are dumping two are not fixed-up in loadup.el before > dump because not referenced by any function. > > In particular looking at 'ediff-hook' it does contain only variable > definitions so this is correct. > > We do run a GC before dumping so we should unload these unreferenced CUs > before dump. And as expected I don't see ediff-hook CU being marked but > we do not free it during sweep. > > It looks to me like a GC bug so far. Unfortunatly I've very constrained > time to dedicate on this this week. Thinking about this... Maybe relying on the GC for this is not a very good idea in the first place. If we are conservative on the stack my might always mark a CU accidentally and fall into the same issue. I think we should maintain a list of all loaded CUs so we can fix them up reliably. If this is agreed not to be a bad idea I'll prepare a patch. BR Andrea PS still dunno what's going on with the GC here