From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: make check error in native compiler resulting from commit 1cd188799f86bcb13ad76e82e3436b1b7e9f9e9f on 2021-12-30. Date: Fri, 04 Feb 2022 14:58:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Feb 04 16:03:37 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nG07d-0006U4-8G for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 16:03:37 +0100 Original-Received: from localhost ([::1]:39222 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nG07b-0000kS-Lb for ged-emacs-devel@m.gmane-mx.org; Fri, 04 Feb 2022 10:03:35 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50598) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG032-0007cS-DA for emacs-devel@gnu.org; Fri, 04 Feb 2022 09:58:52 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:64533) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nG02z-0006ti-Ve for emacs-devel@gnu.org; Fri, 04 Feb 2022 09:58:52 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 214Ewl6M021493 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Fri, 4 Feb 2022 14:58:48 GMT In-Reply-To: (Andrea Corallo's message of "Fri, 04 Feb 2022 14:11:03 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285865 Archived-At: Andrea Corallo writes: > Alan Mackenzie writes: > >> Hello, Andrea. >> >> In that patch, I made the following change so that a comparison >> involving Qnil would not go through the (newly) expensive emit_EQ: >> >> diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el >> index 0a10505257..8581fe8066 100644 >> --- a/lisp/emacs-lisp/comp.el >> +++ b/lisp/emacs-lisp/comp.el >> @@ -1829,9 +1829,7 @@ comp-limplify-lap-inst >> (byte-listp auto) >> (byte-eq auto) >> (byte-memq auto) >> - (byte-not >> - (comp-emit-set-call (comp-call 'eq (comp-slot-n (comp-sp)) >> - (make-comp-mvar :constant nil)))) >> + (byte-not null) >> (byte-car auto) >> (byte-cdr auto) >> (byte-cons auto) Yeah, I think reverting this hunk and keeping the `eq' explicit in LIMPLE is the right thing to do, it solves this specific issue and we get back null and not inlined for free. The explicit `eq' gets already nicely handled by the logic you have added in comp.c:2244 so we emit libgccjit IR using emit_BASE_EQ in this case. I've pushed dcf30f14f9 to do that as it works here. Thanks Andrea