From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Correct byte compiler error/warning positions. The solution! Date: Thu, 02 Dec 2021 16:31:55 +0000 Message-ID: References: <83ilwcyc6o.fsf@gnu.org> <8335nfw2pe.fsf@gnu.org> <838rx4s224.fsf@gnu.org> <834k7ss172.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40690"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 02 17:32:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msp0y-000AS6-36 for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 17:32:56 +0100 Original-Received: from localhost ([::1]:58906 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msp0w-0002Fe-Qz for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 11:32:54 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:51700) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msp0A-0001ZJ-2t for emacs-devel@gnu.org; Thu, 02 Dec 2021 11:32:06 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:65464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msp07-0003cP-B7; Thu, 02 Dec 2021 11:32:05 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 1B2GVt7u028119 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 2 Dec 2021 16:31:58 GMT In-Reply-To: (Alan Mackenzie's message of "Thu, 2 Dec 2021 11:21:13 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280764 Archived-At: Alan Mackenzie writes: > Hello, Andrea. Hi Alan, > On Wed, Dec 01, 2021 at 17:53:03 +0000, Andrea Corallo wrote: >> Eli Zaretskii writes: > >> [...] > >> > If all the benchmarks show a slowdown <= 1%, I'm okay with merging it. > >> > Thanks. > >> Another quick note, I think we should evaluate the impact not only with >> different benchmarks but also using a native compiled build (ATM the >> branch has no support for that). > > The change to the scratch/correct-warning-pos branch to work with native > compilation is probably quite small, Not so sure about that > but I don't know the native code > compiler (comp.el, etc.) at all. > > Would you help me with it, please. Sure > The mechanism of the change was introducing @dfn{symbols with position}. > These are embodied in src/lisp.h with a new type tag > PVEC_SYMBOL_WITH_POS, and the type struct Lisp_Symbol_With_Pos. > > The most pertinent changes in the branch are likewise those in > src/lisp.h. There, there's a new flag variable, > symbols_with_pos_enabled, which is tested in the macros lisp_h_EQ, > lisp_h_SYMBOLP, and in the inline function XSYMBOL. There are new > "primitive" macros, lisp_h_BASE_EQ, lisp_h_BARE_SYMBOL_P, and the inline > function XBARE_SYMBOL. There are a few other things too, like > lisp_h_SYMBOL_WITH_POS_P. > > All these changes can be seen with a git diff between the branch head > and the branch point in the master branch. The modifications needed are all and only going into comp.c. The function you have to extend is 'emit_EQ'. You'll see we have an emit_* function for each corresponding macro/inline function used, ex: 'emit_XLI', 'emit_XCONS' etc... You'll have to define all the new one needed in order to use them use them in the new 'emit_EQ'. Best Regards Andrea