From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Time to merge scratch/correct-warning-pos into master, perhaps? Date: Tue, 25 Jan 2022 21:30:10 +0000 Message-ID: References: <837darmygd.fsf@gnu.org> <58bb8030d59733b52b8d@heytings.org> <83r18zkmd5.fsf@gnu.org> <835yq9ls7j.fsf@gnu.org> <058b682b11240176288f@heytings.org> <83h79tjd2f.fsf@gnu.org> <058b682b11f58780b580@heytings.org> <83v8y8ij39.fsf@gnu.org> <6a5bb5a08b3d764611f9@heytings.org> <6a5bb5a08b93601c5708@heytings.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20265"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: mattiase@acm.org, emacs-devel@gnu.org, monnier@iro.umontreal.ca, Alan Mackenzie , Eli Zaretskii , larsi@gnus.org To: Gregory Heytings Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jan 25 22:33:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nCTRq-00050M-K6 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 22:33:54 +0100 Original-Received: from localhost ([::1]:41354 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nCTRp-0007Yx-72 for ged-emacs-devel@m.gmane-mx.org; Tue, 25 Jan 2022 16:33:53 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:53578) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCTOQ-0004Gm-92 for emacs-devel@gnu.org; Tue, 25 Jan 2022 16:30:23 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:53826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nCTOM-0005xh-LX; Tue, 25 Jan 2022 16:30:21 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 20PLUAdx029519 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 25 Jan 2022 21:30:10 GMT In-Reply-To: <6a5bb5a08b93601c5708@heytings.org> (Gregory Heytings's message of "Tue, 25 Jan 2022 21:15:11 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:285398 Archived-At: Gregory Heytings writes: >>> Are there other benchmarks (not micro-benchmarks) that could be >>> used to reach what you would consider a mature conclusion? >> >> There is Andrea Corallo's elisp-benchmark package. >> > > It's a micro-benchmark, and moreover it is difficult to interpret, its > results on the same (unloaded) machine with the same version of Emacs > vary by +/- 5%. Hi Gregory, if your system is noisy you can increase `elb-runs' to an higher value, in the results an estimation of the error anyway is given (probably more reliable with ~ elb-runs >= 5?). That said yes, is a suite of micro benchmarks but it's better than nothing. Actually it would be *very* interesting to add to elisp-benchmark a micro benchmark capable of stressing exactly this supposed performance regression. It would really help understanding the (observed?) slowdown. Initially when the branch was proposed I tried quickly to do that but I failed, maybe I was rushing due to lack of time and overlooked something or maybe except for the compilation phase the slowdown is really minimal, dunno. I encourage you to try my same experiment, if you find an interesting case we'll add it to the suite. Thanks Andrea