From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: feature/jit-improved-type-punning 9d2a54bd8d: src/comp.c: Use libgccjit's bitcast API for type coercion, when available. Date: Tue, 04 Oct 2022 18:44:38 +0000 Message-ID: References: <166430063807.1861.17209317756638644499@vcs2.savannah.gnu.org> <20220927174358.8443FC00A6E@vcs2.savannah.gnu.org> <87y1u473g3.fsf@yahoo.com> <83pmffiwko.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34514"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Po Lu , emacs-devel@gnu.org, vibhavp@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Oct 04 20:48:41 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofmy9-0008q8-Gb for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Oct 2022 20:48:41 +0200 Original-Received: from localhost ([::1]:59438 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofmy8-0000lz-21 for ged-emacs-devel@m.gmane-mx.org; Tue, 04 Oct 2022 14:48:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofmuJ-0006cU-Dd for emacs-devel@gnu.org; Tue, 04 Oct 2022 14:44:46 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:58744) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofmuH-0005Fe-90; Tue, 04 Oct 2022 14:44:43 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 294IibXX009373 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Tue, 4 Oct 2022 18:44:37 GMT In-Reply-To: <83pmffiwko.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 28 Sep 2022 14:10:15 +0300") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296921 Archived-At: Eli Zaretskii writes: >> From: Po Lu >> Cc: Vibhav Pant >> Date: Wed, 28 Sep 2022 08:22:36 +0800 >> >> BTW, I don't see any code that loads this function dynamically on MS >> Windows. Isn't that needed? > > They were present in the patch that was posted. > > FWIW, I'd like to see some rationale for these changes. Perhaps > libgccjit experts would see it immediately without any explanations, > but I'm not such an expert. TIA. I think having explicit casts expressed to the compiler (instead of working it around with unions as we do now) could enable the compiler for better optimizations or maybe even some compile time gain. Before libgccjit did not allow for expressing it, so it's good that now we take advantage of it when available. Best Regards Andrea