From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: changed dlopen flags in dynlib.c, gccemacs crash Date: Wed, 15 Dec 2021 15:26:20 +0000 Message-ID: References: <83tufjw848.fsf@gnu.org> <83lf0uuqaq.fsf@gnu.org> <83o85nr1mm.fsf@gnu.org> <83tuffov9n.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="38310"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: silent2600@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Dec 15 16:28:40 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mxWCt-0009mE-Kv for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Dec 2021 16:28:39 +0100 Original-Received: from localhost ([::1]:54240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mxWCq-0004JW-Ot for ged-emacs-devel@m.gmane-mx.org; Wed, 15 Dec 2021 10:28:36 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:39732) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxWAj-00023t-VJ for emacs-devel@gnu.org; Wed, 15 Dec 2021 10:26:26 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:59529) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mxWAg-0006l7-V0; Wed, 15 Dec 2021 10:26:25 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 1BFFQKKe020675 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Wed, 15 Dec 2021 15:26:20 GMT In-Reply-To: (Andrea Corallo's message of "Sat, 11 Dec 2021 20:53:23 +0000") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:282056 Archived-At: Andrea Corallo writes: > Eli Zaretskii writes: > >>> From: Andrea Corallo >>> Cc: hx , emacs-devel@gnu.org >>> Date: Sat, 11 Dec 2021 18:09:56 +0000 >>> >>> > So at this point, I think this bug report should be treated as >>> > "wishlist", i.e. a feature request: to support RTLD_GLOBAL in dynlib >>> > with native-comp. Andrea, is that feasible, and if so, what would it >>> > entail? >>> >>> Hi Eli, >>> >>> yes, I think once we have verified the issue is what we suspect we could >>> dlopen eln files as before and have RTLD_GLOBAL added for the other >>> cases. >>> >>> I'll have a look into next week and report on the feature request. >> >> Thanks. One (unchecked) idea is to use 2 different versions of >> dynlib_open: one for loading *.eln files, the other for every other >> kind of dynamic loading. > > Agree, 2 different versions of dynlib_open was my idea as well. Hi all, I've implemented the mentioned idea of having two different 'dynlib_open' and pushed that as e6b93245fe. Contextually I've added the RTLD_GLOBAL flag to 'dlopen'. Note the Windows version of the new 'dynlib_open' is just a wrapper to the old one as I don't know if something has to be done there or not (nor I know how to test it). BR Andrea