From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Native compiler - passing command line options to C compiler Date: Mon, 30 Aug 2021 09:36:09 +0000 Message-ID: References: Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="24400"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 30 11:36:54 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKdio-00068V-EK for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 11:36:54 +0200 Original-Received: from localhost ([::1]:54936 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKdim-0004hs-SY for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 05:36:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKdiB-0003xn-To for emacs-devel@gnu.org; Mon, 30 Aug 2021 05:36:15 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:51555) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKdi9-0007zm-PC for emacs-devel@gnu.org; Mon, 30 Aug 2021 05:36:15 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 17U9aApH021486 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 30 Aug 2021 09:36:10 GMT In-Reply-To: (Arthur Miller's message of "Sun, 29 Aug 2021 23:47:56 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273471 Archived-At: Arthur Miller writes: > Hi again, > > after the few mails the other day, I wasn't really sure if Andrea is going to > implement it and when. Sure I was going to implent it as I said so, but thanks for taking the task :) > I thought it was rather a tedious manual labour and maybe > not so important, so I took me a liberty to implement this myself in my own, so > called, personal copy of Eamcs sources. > > I am not sure if I have done it correctly though, I appreciate if Andrea have > time to take a look; I just have a small suggestion. > Mark set > > diff --git a/lisp/emacs-lisp/comp.el b/lisp/emacs-lisp/comp.el > index 80a1da5ad8..58d361cf46 100644 > --- a/lisp/emacs-lisp/comp.el > +++ b/lisp/emacs-lisp/comp.el > @@ -166,6 +166,16 @@ native-comp-async-query-on-exit > :type 'boolean > :version "28.1") > > +(defcustom native-comp-compiler-options nil > + "Options passed verbatim to the native compiler's c driver. I'd just say "passed to the compiler" or "passed to GCC" as there's no C involed. > +#endif > + if (CONSP (options)) > + xsignal1 (Qnative_compiler_error, > + build_string ("Customizing native compiler options" > + " via `comp-native-compiler-options' is" > + " only available on libgccjit version 9" > + " and above.")); > + > + /* Captured `comp-native-driver-options' because file-local. */ ^^^ native-comp-compiler-options ? Other that that the patch LGTM. Could you provide it with its Changelog? TIA Andrea