From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: Native compiler - passing command line options to C compiler Date: Mon, 30 Aug 2021 15:38:44 +0000 Message-ID: References: <83bl5fkvky.fsf@gnu.org> <83v93njc3x.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11878"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Arthur Miller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 30 17:39:32 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mKjNj-0002vt-OE for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 17:39:31 +0200 Original-Received: from localhost ([::1]:51604 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mKjNi-0003NJ-8z for ged-emacs-devel@m.gmane-mx.org; Mon, 30 Aug 2021 11:39:30 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37664) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjN3-0002cB-HX for emacs-devel@gnu.org; Mon, 30 Aug 2021 11:38:49 -0400 Original-Received: from mx.sdf.org ([205.166.94.24]:51826) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mKjN1-00089I-E0; Mon, 30 Aug 2021 11:38:49 -0400 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 17UFci6L018575 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Mon, 30 Aug 2021 15:38:45 GMT In-Reply-To: (Arthur Miller's message of "Mon, 30 Aug 2021 17:00:08 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:273507 Archived-At: Arthur Miller writes: > Andrea Corallo writes: > >> Eli Zaretskii writes: >> >>>> From: Andrea Corallo >>>> Cc: Arthur Miller , emacs-devel@gnu.org >>>> Date: Mon, 30 Aug 2021 12:59:45 +0000 >>>> >>>> I think this "defined (WINDOWSNT)" should be there so that compiling on >>>> Windows the check over "gcc_jit_context_add_command_line_option" it is >>>> always compiled even in case the libgccjit.h provided at compile time >>>> does not define >>>> 'LIBGCCJIT_HAVE_gcc_jit_context_add_command_line_option'. >>>> >>>> A newer version of the shared library including the entry point might be >>>> provided later on and will be used at runtime. >>> >>> You cannot use a libgccjit.dll of a version for which Emacs was not >>> compiled, unless it is binary-compatible. If Emacs was linked against >>> libgccjit.dll that didn't support >>> gcc_jit_context_add_command_line_option, then it would not work to >>> install a newer version of the DLL that does. >> >> Okay, I thought on Windows worked differently and we could handle the >> case of a symbol not available at compile time but at runtime. In the >> light of this we can probably perform some more clean-up. > > So does that mean that windows check is not needed in add_driver_options as well? AFAIR that was the reason for that check so yes. Andrea