From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: Bug#38708: eq vs eql in byte-compiled code Date: Tue, 31 Dec 2019 15:51:09 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="120773"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: mattiase@acm.org, eliz@gnu.org, emacs-devel@gnu.org To: Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 31 16:52:04 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1imJoS-000VHL-3K for ged-emacs-devel@m.gmane.org; Tue, 31 Dec 2019 16:52:04 +0100 Original-Received: from localhost ([::1]:43774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imJoQ-0006FH-NJ for ged-emacs-devel@m.gmane.org; Tue, 31 Dec 2019 10:52:02 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53740) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1imJnk-0005KJ-Ck for emacs-devel@gnu.org; Tue, 31 Dec 2019 10:51:21 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1imJnj-0000WK-EQ for emacs-devel@gnu.org; Tue, 31 Dec 2019 10:51:20 -0500 Original-Received: from mx.sdf.org ([205.166.94.20]:54145) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1imJnh-00006H-El; Tue, 31 Dec 2019 10:51:17 -0500 Original-Received: from sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id xBVFpAli022270 (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256 bits) verified NO); Tue, 31 Dec 2019 15:51:10 GMT Original-Received: (from akrl@localhost) by sdf.org (8.15.2/8.12.8/Submit) id xBVFp9xO029056; Tue, 31 Dec 2019 15:51:09 GMT In-Reply-To: (Pip Cet's message of "Tue, 31 Dec 2019 15:07:11 +0000") X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 205.166.94.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243811 Archived-At: Pip Cet writes: > The reason for this is that (eq 1.0 1.0) is optimized to nil before > the constants are deduplicated, but other function calls use the > deduplicated values. If using eq (comparing words) on things that are not symbols has unpredictable results I don't see the problem if this is true in the run-time as in the compile-time. I agree that having eq and eql equivalent would be probably too expensive in terms of performance. Generally speaking I like to be able to use 'eq' for what it is its classical definition. -- akrl@sdf.org