From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo Newsgroups: gmane.emacs.devel Subject: Re: [External] : emacs-28 windows binaries available from alpha Date: Thu, 10 Feb 2022 08:56:50 +0000 Message-ID: References: <834k5d3hbv.fsf@gnu.org> <83o83l1v51.fsf@gnu.org> <83k0e3vox9.fsf@gnu.org> <83fsoruv2u.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27286"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 10 10:11:58 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nI5UZ-0006mI-6l for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Feb 2022 10:11:55 +0100 Original-Received: from localhost ([::1]:32866 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nI5UW-0005Ms-IA for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Feb 2022 04:11:52 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:58362) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI5GE-0001t8-5V for emacs-devel@gnu.org; Thu, 10 Feb 2022 03:57:06 -0500 Original-Received: from mx.sdf.org ([205.166.94.24]:60339) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nI5GB-0007nC-IA; Thu, 10 Feb 2022 03:57:05 -0500 Original-Received: from ma.sdf.org (ma.sdf.org [205.166.94.33]) by mx.sdf.org (8.15.2/8.14.5) with ESMTPS id 21A8uoRh012255 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits) verified NO); Thu, 10 Feb 2022 08:56:50 GMT In-Reply-To: <83fsoruv2u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Feb 2022 07:52:41 +0200") Received-SPF: pass client-ip=205.166.94.24; envelope-from=akrl@sdf.org; helo=mx.sdf.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286129 Archived-At: --=-=-= Content-Type: text/plain Eli Zaretskii writes: >> From: Andrea Corallo >> Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org >> Date: Wed, 09 Feb 2022 21:03:39 +0000 >> >> Wouldn't be better to call explicitly `native-comp-available-p' from >> startup.el and set the two variables from there? > > Fine with me. Could you suggest a good place for that call? I'd propose the following patch: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-lisp-startup.el-normal-top-level-Disable-native-comp.patch >From 4bdbf3c76394e6d83f4a2bbb582ae0549674512c Mon Sep 17 00:00:00 2001 From: Andrea Corallo Date: Thu, 10 Feb 2022 09:46:31 +0100 Subject: [PATCH] * lisp/startup.el (normal-top-level): Disable native-comp if not available --- lisp/startup.el | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lisp/startup.el b/lisp/startup.el index 71e492e3b4..cccaa90e9c 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -537,6 +537,10 @@ normal-top-level (setq user-emacs-directory (startup--xdg-or-homedot startup--xdg-config-home-emacs nil)) + (unless (native-comp-available-p) + (setq native-comp-deferred-compilation nil + comp-enable-subr-trampolines nil)) + (when (featurep 'native-compile) ;; Form `native-comp-eln-load-path'. (let ((path-env (getenv "EMACSNATIVELOADPATH"))) -- 2.20.1 --=-=-= Content-Type: text/plain This way we set the two variables just before doing the `native-comp-eln-load-path' job. So essentially before the native compiler is usable. *Also* I'm now wondering if we shouldn't rename `comp-enable-subr-trampolines' into `native-comp-enable-subr-trampolines' (if it's not to late...) > And I understand that you are suggesting that _in_addition_ to the > patch I proposed, right? I think my change should be sufficient, maybe you see a reason why we should set these two every time we pass in `native-comp-available-p'? Thanks Andrea --=-=-=--