From: Andrea Corallo <akrl@sdf.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org
Subject: Re: [External] : emacs-28 windows binaries available from alpha
Date: Thu, 10 Feb 2022 08:56:50 +0000 [thread overview]
Message-ID: <xjf7da3t7zh.fsf@ma.sdf.org> (raw)
In-Reply-To: <83fsoruv2u.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 10 Feb 2022 07:52:41 +0200")
[-- Attachment #1: Type: text/plain, Size: 417 bytes --]
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: dieter@duenenhof-wilhelm.de, corwin@bru.st, emacs-devel@gnu.org
>> Date: Wed, 09 Feb 2022 21:03:39 +0000
>>
>> Wouldn't be better to call explicitly `native-comp-available-p' from
>> startup.el and set the two variables from there?
>
> Fine with me. Could you suggest a good place for that call?
I'd propose the following patch:
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-lisp-startup.el-normal-top-level-Disable-native-comp.patch --]
[-- Type: text/x-diff, Size: 857 bytes --]
From 4bdbf3c76394e6d83f4a2bbb582ae0549674512c Mon Sep 17 00:00:00 2001
From: Andrea Corallo <akrl@sdf.org>
Date: Thu, 10 Feb 2022 09:46:31 +0100
Subject: [PATCH] * lisp/startup.el (normal-top-level): Disable native-comp if
not available
---
lisp/startup.el | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/lisp/startup.el b/lisp/startup.el
index 71e492e3b4..cccaa90e9c 100644
--- a/lisp/startup.el
+++ b/lisp/startup.el
@@ -537,6 +537,10 @@ normal-top-level
(setq user-emacs-directory
(startup--xdg-or-homedot startup--xdg-config-home-emacs nil))
+ (unless (native-comp-available-p)
+ (setq native-comp-deferred-compilation nil
+ comp-enable-subr-trampolines nil))
+
(when (featurep 'native-compile)
;; Form `native-comp-eln-load-path'.
(let ((path-env (getenv "EMACSNATIVELOADPATH")))
--
2.20.1
[-- Attachment #3: Type: text/plain, Size: 550 bytes --]
This way we set the two variables just before doing the
`native-comp-eln-load-path' job. So essentially before the native
compiler is usable.
*Also* I'm now wondering if we shouldn't rename
`comp-enable-subr-trampolines' into
`native-comp-enable-subr-trampolines' (if it's not to late...)
> And I understand that you are suggesting that _in_addition_ to the
> patch I proposed, right?
I think my change should be sufficient, maybe you see a reason why we
should set these two every time we pass in `native-comp-available-p'?
Thanks
Andrea
next prev parent reply other threads:[~2022-02-10 8:56 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 18:54 emacs-28 windows binaries available from alpha Corwin Brust
2022-02-04 22:08 ` [External] : " Drew Adams
2022-02-04 22:12 ` Drew Adams
2022-02-04 23:10 ` Corwin Brust
2022-02-05 1:28 ` Drew Adams
2022-02-05 4:35 ` Corwin Brust
2022-02-05 7:43 ` Eli Zaretskii
2022-02-05 8:48 ` Corwin Brust
2022-02-05 9:15 ` Eli Zaretskii
2022-02-05 18:16 ` Drew Adams
2022-02-05 7:25 ` Eli Zaretskii
2022-02-05 9:22 ` H. Dieter Wilhelm
2022-02-05 9:40 ` Eli Zaretskii
2022-02-05 16:49 ` H. Dieter Wilhelm
2022-02-05 17:54 ` Eli Zaretskii
2022-02-05 19:25 ` H. Dieter Wilhelm
2022-02-05 19:47 ` Eli Zaretskii
2022-02-05 21:11 ` H. Dieter Wilhelm
2022-02-05 22:56 ` Corwin Brust
2022-02-06 0:10 ` Drew Adams
2022-02-06 8:22 ` Eli Zaretskii
2022-02-06 8:51 ` Drew Adams
2022-02-06 9:25 ` Eli Zaretskii
2022-02-06 17:08 ` Drew Adams
2022-02-06 17:33 ` Eli Zaretskii
2022-02-06 8:18 ` Eli Zaretskii
2022-02-05 10:10 ` Eli Zaretskii
2022-02-06 3:11 ` Corwin Brust
2022-02-06 6:57 ` Drew Adams
2022-02-06 9:11 ` Eli Zaretskii
2022-02-06 17:07 ` Drew Adams
2022-02-09 19:08 ` Eli Zaretskii
2022-02-09 21:03 ` Andrea Corallo
2022-02-10 5:52 ` Eli Zaretskii
2022-02-10 8:56 ` Andrea Corallo [this message]
2022-02-10 12:13 ` Eli Zaretskii
2022-02-10 13:36 ` Andrea Corallo
2022-02-10 17:15 ` Eli Zaretskii
2022-02-10 18:34 ` Andrea Corallo
2022-02-11 8:29 ` Eli Zaretskii
2022-02-11 9:16 ` Andrea Corallo
2022-02-11 9:21 ` Andrea Corallo
2022-02-11 11:31 ` Eli Zaretskii
2022-02-11 14:16 ` Andrea Corallo
2022-02-11 14:33 ` Eli Zaretskii
2022-02-11 14:38 ` Andrea Corallo
2022-02-11 11:30 ` Eli Zaretskii
2022-02-11 14:18 ` Andrea Corallo
2022-02-11 14:35 ` Eli Zaretskii
2022-02-11 14:44 ` Andrea Corallo
2022-02-11 15:16 ` Eli Zaretskii
2022-02-14 10:25 ` Andrea Corallo
2022-02-10 22:50 ` Corwin Brust
2022-02-06 0:33 ` Corwin Brust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjf7da3t7zh.fsf@ma.sdf.org \
--to=akrl@sdf.org \
--cc=corwin@bru.st \
--cc=dieter@duenenhof-wilhelm.de \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).