unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Updating *.el files and native compilation
Date: Mon, 10 May 2021 20:45:14 +0000	[thread overview]
Message-ID: <xjf5yzqs4h1.fsf@sdf.org> (raw)
In-Reply-To: <83o8di5xtw.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 10 May 2021 19:59:39 +0300")

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Andrea Corallo <akrl@sdf.org>
>> Cc: emacs-devel@gnu.org
>> Date: Mon, 10 May 2021 15:44:16 +0000
>> 
>> > If so, how can we make sure we never fail to update comp-abi-hash when
>> > that is needed?
>> 
>> The vast majority of the cases is when some subr is added or a signature
>> is changed and we account for this automatically.  The rest should be
>> only about changes specific to the eln load mechanism in comp.c.  I hope
>> who does that is very well aware of consequences but I don't know if
>> there's a way we can automatically guard against these changes breaking
>> the system (I guess there's not).
>
> Maybe you should try writing up the rules for when such a change is
> needed.  Don't worry about the English correctness: it is easy to fix
> that once the text is written.  But I think no one but you knows the
> rules for now, so it should be a good idea to record them.

Okay I can try thinking about something for this, where shall we put it?
In a comment in comp.c (perhaps close to the ABI_VERSION definition)?

  Andrea



  reply	other threads:[~2021-05-10 20:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-08  7:51 Updating *.el files and native compilation Eli Zaretskii
2021-05-10  7:35 ` Andrea Corallo via Emacs development discussions.
2021-05-10 13:34   ` Eli Zaretskii
2021-05-10 15:44     ` Andrea Corallo via Emacs development discussions.
2021-05-10 16:59       ` Eli Zaretskii
2021-05-10 20:45         ` Andrea Corallo via Emacs development discussions. [this message]
2021-05-11  2:27           ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xjf5yzqs4h1.fsf@sdf.org \
    --to=emacs-devel@gnu.org \
    --cc=akrl@sdf.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).