From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andrea Corallo via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 1/1] Stop using legacy -ffat-lto-objects flag Date: Mon, 09 Nov 2020 08:57:51 +0000 Message-ID: References: <878sbby5pz.fsf@eklitzke.org> <838sbb5i3a.fsf@gnu.org> Reply-To: Andrea Corallo Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25177"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: Evan Klitzke , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Nov 09 09:58:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc30k-0006Qu-Mw for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 09:58:50 +0100 Original-Received: from localhost ([::1]:49656 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc30j-00037Q-Ok for ged-emacs-devel@m.gmane-mx.org; Mon, 09 Nov 2020 03:58:49 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50268) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc2zt-0002h7-NX for emacs-devel@gnu.org; Mon, 09 Nov 2020 03:57:57 -0500 Original-Received: from mab.sdf.org ([205.166.94.33]:59696 helo=ma.sdf.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc2zq-0002sr-VF; Mon, 09 Nov 2020 03:57:57 -0500 Original-Received: from akrl by ma.sdf.org with local (Exim 4.92) (envelope-from ) id 1kc2zn-0005cE-8m; Mon, 09 Nov 2020 08:57:51 +0000 In-Reply-To: <838sbb5i3a.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Nov 2020 05:23:21 +0200") Received-SPF: pass client-ip=205.166.94.33; envelope-from=akrl@sdf.org; helo=ma.sdf.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 03:57:52 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:258939 Archived-At: Eli Zaretskii writes: >> From: Evan Klitzke >> Date: Sun, 08 Nov 2020 12:05:28 -0800 >> >> Currently when Emacs is configured using the >> --enable-link-time-optimization configure flag, the build will use the >> -ffat-lto-objects flag if the host compiler is GCC (but not Clang). >> According to the comments in configure.ac this is to work around an >> issue with LTO builds in GCC 4.9.0. This flag makes builds take much >> longer (and produces much larger object files), so I suggest removing it >> as GCC 4.x is quite old at this point and doesn't have great LTO support >> anyway. > > I think this is too soon: fencepost.gnu.org, which runs Trisquel LTS, > still has GCC 4.8.4. > > Thanks. Couldn't we check and decide based on the GCC version? IIUC we already do something like this using gl_GCC_VERSION_IFELSE. Andrea