From: Andrea Corallo via "Emacs development discussions." <emacs-devel@gnu.org>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025).
Date: Thu, 11 Mar 2021 19:29:02 +0000 [thread overview]
Message-ID: <xjf35x1qykh.fsf@sdf.org> (raw)
In-Reply-To: <jwv7dmer3x7.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Wed, 10 Mar 2021 18:23:44 -0500")
Stefan Monnier <monnier@iro.umontreal.ca> writes:
>> -(if (byte-code-function-p (symbol-function 'macroexpand-all))
>> +(if (or (byte-code-function-p (symbol-function 'macroexpand-all))
>> + (subr-native-elisp-p (symbol-function 'macroexpand-all)))
>
> BTW, I find this rather ugly.
I thought this is very similar to one of the two suggested :)
> I think for this specific case, I will be able to come up with a better
> (less ad-hoc/circumstantial) test, but I wonder if this kind of test was
> also needed in enough other places that we might think about providing
> some other test (like `function-interpreted-p` maybe?).
Yep, `function-interpreted-p' might be handy to have.
Thanks
Andrea
next prev parent reply other threads:[~2021-03-11 19:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210310151754.12884.67231@vcs0.savannah.gnu.org>
[not found] ` <20210310151755.C7D8D211CF@vcs0.savannah.gnu.org>
2021-03-10 23:23 ` feature/native-comp 711b2c8 2/2: * lisp/loadup.el: Don't load pcase on native builds (bug#47025) Stefan Monnier
2021-03-11 19:29 ` Andrea Corallo via Emacs development discussions. [this message]
2021-03-11 20:36 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xjf35x1qykh.fsf@sdf.org \
--to=emacs-devel@gnu.org \
--cc=akrl@sdf.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).