From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: Re: vc-set-mode-line-busy-indicator Date: Mon, 03 Mar 2008 16:04:04 -0500 Message-ID: References: <18370.47294.641890.556694@kahikatea.snap.net.nz> <18371.9275.720477.806834@kahikatea.snap.net.nz> <2vzltos6g1.fsf@fencepost.gnu.org> <18371.49683.356527.589505@kahikatea.snap.net.nz> <18377.55334.203888.524043@kahikatea.snap.net.nz> <434pbqcaz5.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1204578337 8246 80.91.229.12 (3 Mar 2008 21:05:37 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 3 Mar 2008 21:05:37 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 03 22:06:03 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JWHqJ-0005jN-CF for ged-emacs-devel@m.gmane.org; Mon, 03 Mar 2008 22:05:15 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JWHpl-0006Kj-O6 for ged-emacs-devel@m.gmane.org; Mon, 03 Mar 2008 16:04:29 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JWHpR-00069r-3u for emacs-devel@gnu.org; Mon, 03 Mar 2008 16:04:09 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JWHpN-00066y-G0 for emacs-devel@gnu.org; Mon, 03 Mar 2008 16:04:08 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JWHpN-00066m-BM for emacs-devel@gnu.org; Mon, 03 Mar 2008 16:04:05 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JWHpN-0003JD-8K for emacs-devel@gnu.org; Mon, 03 Mar 2008 16:04:05 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.67) (envelope-from ) id 1JWHpM-0007q7-Dh; Mon, 03 Mar 2008 16:04:04 -0500 X-Spook: csystems covert video Echelon Soviet kibo top secret X-Ran: +R'G,[b`l/=oYv2.:v`|2@%>Kht7h(J8t&NDZUeQ@xrc?W"N}NV.WpUN\+X,ZaRTc}tLmi X-Hue: yellow X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:91221 Archived-At: Richard Stallman wrote: > Yes. mode-line-highlight (as now) for things you might click, which are > highlighted as buttons on mouse-over. mode-line-emphasis for > "non-interactive" things you don't click, which are always highlighted. > > 1. Do we really need both? (I am worried about face bloat.) No. vc-set-mode-line-busy-indicator can not apply a 'face property for all I care. (I knew this worry about "face bloat" would come up. I don't understand it.) > 2. If we need both, the name of the one for buttons should be > `mode-line-button' and the one for emphasis should be > `mode-line-highlight'. This would be an incompatible change to the use of the existing mode-line-highlight face. > 3. Can we make the one for buttons by means of `button' > instead of having a separate face only for mode line buttons? I'll say, once again, that the mode-line has a different colour scheme to the buffer. Trying to re-use buffer faces in the mode-line can look very poor, as at present with vc-set-mode-line-busy-indicator. I've said all I have to say on this. I've said why the current choice is bad, and I've offered two alternatives (using no 'face at all, or a new one). I'll implement either. But please let's do something, because the current behaviour is broken.