From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv2] textmodes/flyspell.el: Don't check pre-word if buffer was switched. Date: Sat, 20 Apr 2013 11:46:57 -0400 Organization: http://mina86.com/ Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1366472833 2693 80.91.229.3 (20 Apr 2013 15:47:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 20 Apr 2013 15:47:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Agustin Martin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Apr 20 17:47:17 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UTa0S-0007Z0-9W for ged-emacs-devel@m.gmane.org; Sat, 20 Apr 2013 17:47:16 +0200 Original-Received: from localhost ([::1]:39166 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTa0R-0001mP-KJ for ged-emacs-devel@m.gmane.org; Sat, 20 Apr 2013 11:47:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60794) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTa0L-0001mC-EX for emacs-devel@gnu.org; Sat, 20 Apr 2013 11:47:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTa0H-0001gW-4C for emacs-devel@gnu.org; Sat, 20 Apr 2013 11:47:09 -0400 Original-Received: from mail-vb0-x230.google.com ([2607:f8b0:400c:c02::230]:49504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTa0G-0001g9-V1 for emacs-devel@gnu.org; Sat, 20 Apr 2013 11:47:05 -0400 Original-Received: by mail-vb0-f48.google.com with SMTP id p13so4532270vbe.7 for ; Sat, 20 Apr 2013 08:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:organization :references:user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash :x-hashcash:date:message-id:mime-version:content-type; bh=mkmimzlUGxfWuCdAmBoyJV89fM4fJJhuh7THskFNOVY=; b=mSrlyu4XwdRk261WAm15u1H/FgsGJXU1o45qE/bVkaxMoxuuslMq/rdyQtUqstomGG +Hl1uvHfRjZQANuUkyUW2ao80V355zGFj/mDQq8YbvSh+f7VKlLaB7xzM1aB5dx/zizF K356FNaJdpcpLCeYironYLQdjou6Qu6FeAlZUClPc9fSdcNFaTenPfUeKUiSWPjB3MDb mKKcmF6ye+p/eN+Jiam1WN52wktvVN1vnTY1ppl+4TpGKurrJzKHHZsi9ggSvRnxYKUc l4/DwnP76ES1qF+JUQxvkCGOmIYebbTgD1AxLpVZSi9GelWJeChToHkDpNQTnbsbeyWL 2PxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:sender:from:to:cc:subject:in-reply-to:organization :references:user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash :x-hashcash:date:message-id:mime-version:content-type :x-gm-message-state; bh=mkmimzlUGxfWuCdAmBoyJV89fM4fJJhuh7THskFNOVY=; b=UjHevMYBoi35pCBpv8+qq8wOWt+Qu6lv0UPIEwKyN6Ce1SNAe7VgByowraW1xR8+d6 8bBYxF0I9W5tkluDA6r/NRV3/loON1FL/J2dyVPb9QV3MlOlKFCkgddSQXGX3tqGftPm 8phDSiP9tOMCkZUUaQsLdhBTDJ/fmBbO44h7DsZ9mKAlx5XBu5/tDFVx+Dl/xwuJffEn fg/DB6urYUDz94XMQHY8wViYTVm3XTQuJpk9XTaqlTjZ+myM4J1yQhIvhEkPvL/Z4Qgn H+Qye09vvTg7FfA70QLPd4WC72+Cmrl0+9Kr0e7YKJWMB9YcixJzodvHcLziklt7TvbQ mryA== X-Received: by 10.220.153.69 with SMTP id j5mr14565292vcw.35.1366472824122; Sat, 20 Apr 2013 08:47:04 -0700 (PDT) Original-Received: from mpn-glaptop ([97.107.172.132]) by mx.google.com with ESMTPS id mk3sm898052vec.4.2013.04.20.08.47.02 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 20 Apr 2013 08:47:03 -0700 (PDT) In-Reply-To: User-Agent: Notmuch/0.15.2+55~geb6e9d8 (http://notmuchmail.org) Emacs/24.3.50.2 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR 4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:130420:agustin.martin@hispalinux.es::ld4En9E/MyvHeh1C:0000000000000000000000000000000002vi1 X-Hashcash: 1:20:130420:emacs-devel@gnu.org::rtRqcAgZIH93Ct6H:000000000000000000000000000000000000000000AH1p X-Gm-Message-State: ALoCoQk/ljqlDbRa/jJtOHu531vPw+kZp1jwuKGbV/gRgouGNe5Mdkkkh7bcwK3ZEOPRZLivUI7E1vUHufoB1akXXrQJaCqrs+FC+lKL2yMga17ByebtTYlhEj8nzuRb9gP2J6FQOuLbeo1JVBLPDBgz0PdpTra3mqXdz9BNnNztPybN1qRp0dXXxC+of/xrqJOSzmzy8e6e6Hkl9xnHC/756StrIbK77w== X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2607:f8b0:400c:c02::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:159053 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Sat, Apr 20 2013, Agustin Martin wrote: > After that I tried harder to reproduce the problem with the original > unchanged code without success, so I have my doubts about this change bei= ng > really needed or the best one, `(numberp flyspell-pre-point)' test should > already care of nil `flyspell-pre-point'. Not exactly. (numberp flyspell-pre-point) checks the variable before buffer is switched in `flyspell-post-command-hook' at which point the variable changes the value. I confess that I'm not sure how the variable may be nil in given buffer with `flyspell-pre-buffer' not being nil since those are always set together, but for some reason I experienced a behaviour which I could only explain if the following is true: (and flyspell-pre-buffer (with-current-buffer flyspell-pre-buffer (not flyspell-pre-point))) > I'd appreciate a minimal step-by-step guide to reproduce the original > problem with the original code, if it can be systematically > reproduced. If it appeared randomly, please provide as much info as > you can. I was experiencing the problem every time I sent an email signed with PGG. I've never experienced it doing anything else or sending the mail without signature. The error in *Messages* reads: Error in post-command-hook (flyspell-post-command-hook): (wrong-type-argum= ent integer-or-marker-p nil) Unfortunately, I wasn't able to get a minimal set of configuration which makes the problem appear, so it may be caused by interactions which whatever hundred of configuration options I'm using. If you wish to take a look, my configuration files are: * https://github.com/mina86/dot-files/blob/master/dot-emacs * https://github.com/mina86/dot-files/blob/master/dot-mail If you want I can try and take a deeper look later on, but cannot promise anything this week. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJRcrhxAAoJECBgQBJQdR/0YfgP/ijyVSa0xAy535DXT9cCtEd7 Hgtoo7VO5ChWmOgi03vLgrW3Mz3k7Cxk6DzdYS9U8+K9gZbwnykqRTYcbPagN7tg HAXTlsverILscJYHAQ3MtjXnKw+gClEl0NRIK2gT/onVa3kziHYUZFbWgL50QC9t rv/0IRFsRZftAu+SCdVq0hsFFkESyMCnVkBaWXQKM6k6vsDWNp8ZFtQIsGfI7RC+ vMa55AZEeAgmuXtJ5akQZJhngj0VpiIKkVyNKjc1SMZdKPRy/QCWWCfJer2pRuuC JQcbuJi4WXnNBFn6HuleS+fUpu0VqzipWRC/bfgMjADYN1XNSpGh/lXyo7mQ5+sb cx0aeEhGaowyWSpvPpjEOiDc13YkfUR/Otu6+FvvvoYTVdtCDyOTHroQgj6jB1z1 f7hcu2GikzahOILEIfZjz9lWl425/IFwq0t/MG0il7Xw3yybRaQR7snR3LALERvZ Rv1z4BpQFUr5IHX5bO1jKXae2CX2espBacGFgDxnE7P2lvlB5mPfa/gY1NlPY4Jr /phOumYzo6TERTXi0iAisbekFprj8WCkTUkJ5yuPRBIrHSm+sErrzqe/EUQOTQJK 00t1AAt2o/gu5MS8YUqlmIlXNV7mGCn0OhAjg4BaGMniuVSWn5C/CKKZ3BlgcdAf gpKEwqtJcFWPYxufMUkW =ZLXi -----END PGP SIGNATURE----- --==-=-=-- --=-=-=--