From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv4 1/4] `kill-buffer' runs query functions before checking buffer modification. Date: Mon, 24 Jun 2013 20:31:46 +0200 Organization: http://mina86.com/ Message-ID: References: <1c8f2cfbb1b7a321184c6d840763f1c60bbfc95b.1372076606.git.mina86@mina86.com> <51C87C47.4090300@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1372098725 14841 80.91.229.3 (24 Jun 2013 18:32:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2013 18:32:05 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 24 20:32:06 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrBYb-0006QX-H2 for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 20:32:05 +0200 Original-Received: from localhost ([::1]:49805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBYb-0004kD-5T for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 14:32:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47722) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBYU-0004fW-1U for emacs-devel@gnu.org; Mon, 24 Jun 2013 14:32:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrBYQ-0005El-3Y for emacs-devel@gnu.org; Mon, 24 Jun 2013 14:31:57 -0400 Original-Received: from mail-ea0-x232.google.com ([2a00:1450:4013:c01::232]:63102) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrBYP-0005Eg-QS for emacs-devel@gnu.org; Mon, 24 Jun 2013 14:31:54 -0400 Original-Received: by mail-ea0-f178.google.com with SMTP id l15so6360088eak.9 for ; Mon, 24 Jun 2013 11:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type; bh=e4EbSWpeRcPZk+0GqFSLHdYgZtC/B56uzZYA7DFhkhE=; b=Jv2hnWO3ISe2qdcnMwYT3Flw9TO5gLb3iD6J0MWtRyFuHLlMSmfX8SMT1pknWRbAN7 3/2jlfIj9R4kUnupn5E7lAsgBpdk6XrHx8ADKJbHVN6hTAIqxCCf18qCaRivjkBFdHNQ c0fcgtVLwqRAmYOcH1+HjoIhIRbskRFDRA/q2KbjoOo3qK2DNfc3znh1C/gIJrhLeW/x 1AUDszCcKiXYC3r6/EJkRtzeBTaTG/zxTIc+S2fZT4zDXTtET1uj1aQ1dk/YPWSnyKJQ j2YZqmkLJ6eRyQqkDCmuQV9OIBKw0nzZPXEOK4QiUbE5qH6Heu9CsgGSErDy1NRIA05v Litg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type :x-gm-message-state; bh=e4EbSWpeRcPZk+0GqFSLHdYgZtC/B56uzZYA7DFhkhE=; b=VNO1G9651Z+ZI97shJiQ85uBbP07qloBTDnigrs0FF3eqJ/iqCS0ikY3IGos4tkenK FGDbUbvMVWzJb6yjjlL1RQIQek6ar3cdnu5jTEO3lnyKfeW4B7frkvuNgYVp8GsAL7Vr wTaPdwnHO1fYTFZXMIryboQlIRsRlZ2eGD1TJtj9VN/2PCVxefjx4w+3+nu5YQAepnYc 647mWT9X+sXSIk7fpKqFWunKKvUcMg/pvzy8o8w1BwDKoAicsRlQ55zLYt9mGPE3KJ4o iUIvakmu8ZCLeKzFzJkveorLVEnwq6OKeAOlvdGDi5HvZ9F1fm9hDs3HRsXF91OuBqPC MjfA== X-Received: by 10.14.178.134 with SMTP id f6mr25724379eem.91.1372098712960; Mon, 24 Jun 2013 11:31:52 -0700 (PDT) Original-Received: from mpn-glaptop ([2620:0:105f:301:2ddc:c978:be37:615e]) by mx.google.com with ESMTPSA id ci50sm30228429eeb.12.2013.06.24.11.31.51 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 24 Jun 2013 11:31:52 -0700 (PDT) In-Reply-To: <51C87C47.4090300@gmx.at> User-Agent: Notmuch/0.15.2+55~geb6e9d8 (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR 4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:130624:rudalics@gmx.at::Lx+VtblkpL08mIh2:002Dtw X-Hashcash: 1:20:130624:monnier@iro.umontreal.ca::/PFoOR8t9Fra3q4W:0000000000000000000000000000000000000FLSH X-Hashcash: 1:20:130624:emacs-devel@gnu.org::VsyQn68mkwOnivUC:000000000000000000000000000000000000000000HQVW X-Gm-Message-State: ALoCoQmtuEE9jKDaEgG+migvsqqLXvx7852DMPygjvZO1VpE6PkFNTHYtuOLzsVZZ4rHJ7KSTtYnPEv3CVYgARQRP5sj9Um1EjpamkwAcGV0r0hp85rD0L6CMePdCOgY22taKd9c3NF0xjXNtcSWRSVYKmY48OSFjmfwb9eoxuXlAgV5EjDKVXs75DzymAH3s/s5Rhx2EASFlxbaZzoElWoy7CznSgZDgg== X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c01::232 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160967 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jun 24 2013, martin rudalics wrote: > > * buffer.c (FKill_buffer): Run `kill-buffer-query-functions' > > before checking whether buffer is modified. This lets > > `kill-buffer-query-functions' cancel killing of the buffer or save > > its content before `kill-buffer' asks user the "Buffer %s > > modified; kill anyway?" question. > > We probably should guard against the case that the query functions > manage to kill the buffer prematurely. Except this would exactly defeat the purposes of this change. Unless I don't understand what you mean by =E2=80=9Cprematurely=E2=80=9D. I'm ass= uming you want to prevent a function from doing: (set-buffer-modified-p nil) (let (kill-buffer-query-functions) (kill-buffer (current-buffer))) or just that part without let. But (set-buffer-modified-p nil) is exactly what remember-notes--kill-buffer-query wants to do (admittedly saving the contents prior). --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJRyJCSAAoJECBgQBJQdR/0MgYP/3P38i5Kd4h5jVPeZOn8dOnL iJ+G+ech7j2Dn//wsYLCaukpIMi7DgctesYSS7wjZU0D+rjECVZqMI+LBhhFKMR8 bqEHZ3Eg+2juK5HGWnPApILj8DMIKXU2r/cnERZgCVkeAamQHuki1eHcrqXOH5oK jc3DI4epZ6y/snWBDNFrYHyB/DfE7aTmyeJn8hKzYKdOPI8q1wyH3wvKWU7EEjSP yZiCikoD7+MRPYTajhal+btkbkBXzVMk9ZRh+XE8qqlkSFnPKMNqMrjFY1fgVbUN rJBu99JslTWWq/Or6U3bQSZgFilFAyiaY5ob5Z17l/5vFX9NQ4mKBPwPVtQC5Lyr gqOHVUs8OyjU5eA+N+yJYLfYZDIAPlzSSo40NsVL6KAq1+vp5Lm3/8qR4zFZ5cjT A1zP9M8A4qpFdC/f2C8S1UYB67MxCiyugSan964lmr2Uh0MXGE/g+r4PXhUE5+oz x8Bwt5p/tCnaYeacPE+ThVRmbTFR3eiDlP+RVB9SSrOiIZmvBDAq7R0jkOi+wHhG iRTAlevPcSAAJ0Xoe2dgCKx0jsp6so2XBTSDs3sLyEui+eyL8vUxi/7qhiHfsZon UoroU70ow3bkQIkStCoz2EspLOel4SX38iLpJiO//VAUp1AGfcqbO6XNcVW9MKJo G3VOTaaNWbThHcmwSJUm =XnUu -----END PGP SIGNATURE----- --==-=-=-- --=-=-=--