From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michal Nazarewicz Newsgroups: gmane.emacs.devel Subject: Re: [PATCHv4 1/4] `kill-buffer' runs query functions before checking buffer modification. Date: Tue, 25 Jun 2013 00:35:32 +0200 Organization: http://mina86.com/ Message-ID: References: <1c8f2cfbb1b7a321184c6d840763f1c60bbfc95b.1372076606.git.mina86@mina86.com> <51C87C47.4090300@gmx.at> <51C8B2AF.2090409@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1372113354 6092 80.91.229.3 (24 Jun 2013 22:35:54 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Jun 2013 22:35:54 +0000 (UTC) Cc: Stefan Monnier , emacs-devel@gnu.org To: martin rudalics Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 25 00:35:55 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UrFMY-000159-4k for ged-emacs-devel@m.gmane.org; Tue, 25 Jun 2013 00:35:54 +0200 Original-Received: from localhost ([::1]:41164 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrFMX-0006jF-8S for ged-emacs-devel@m.gmane.org; Mon, 24 Jun 2013 18:35:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrFMP-0006j6-2D for emacs-devel@gnu.org; Mon, 24 Jun 2013 18:35:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UrFML-00055j-3m for emacs-devel@gnu.org; Mon, 24 Jun 2013 18:35:44 -0400 Original-Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:32916) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UrFMK-00054m-FS for emacs-devel@gnu.org; Mon, 24 Jun 2013 18:35:40 -0400 Original-Received: by mail-ee0-f41.google.com with SMTP id d17so6285333eek.14 for ; Mon, 24 Jun 2013 15:35:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type; bh=hTsSGbb1a2DnraqyhPFB9cTe4fue7MuQNPVw6BP6W4I=; b=Z6eZ9wBFaEYWu/IXb5T7NSj+8ZfXdKulU8Z/W2rQHoRYtDq8InId7RtbypD2mUn33A x1df98DYX+UBIsHBiO/OrGdXxA+jrDKPYseAcmvHnm65iV2et1UvchQsPTHwB/CMLRaj 7QvljH+Ze6P9rqRKkvjgpAgtkeR5sjgcRTcsK/ZKviWCfefCfJ4uXF9ugQJLZjnFFjJE kUm0FRsG4p9Vs3kTwDKS/cZdEqQBEUKjIOFm2Vwk2/wE5uyLDerfjEFLxUvaa9Qgtj5x pu8gkzRWBSK0uSbwqAF3XDYGKCEpHIREJxCajUI7DN+xya6LhHggb1X7HJoXOmOyB4gt KdXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:organization:references :user-agent:x-face:face:x-pgp:x-pgp-fp:x-hashcash:x-hashcash :x-hashcash:date:message-id:mime-version:content-type :x-gm-message-state; bh=hTsSGbb1a2DnraqyhPFB9cTe4fue7MuQNPVw6BP6W4I=; b=SIWi0rIJdzUyfMLfT1klI+i/KHY5adKotnDUDiUYHfU2khb2IkgZDKFhZzrVSgNb7K WKhk0ahKU4r2ZM39XO5kKtrKSkmimIvfU2bllSqjhpMJz4OlVRToYhSKlAdSqLYD1Ul8 VH/vCvJJszRqUgcf/YNVTjwrUfUEDBKLLlcTyV1aMDAkae8kHL9xrJhCoXtbbwbp0IPG q1UH2zYITmKkX0ntxOtXenAN5EKRMAdruf3K1FOaIsDg3q4rwp0EMgTqIFr3nCy+gauB PEbcySvZ9agd9RJpHhwCkII9lMJ1zWsxXczuNLm83b2cDVlJ2Kpx2a3cQZCjL1y8MyH7 ehsA== X-Received: by 10.14.172.194 with SMTP id t42mr26859273eel.78.1372113339479; Mon, 24 Jun 2013 15:35:39 -0700 (PDT) Original-Received: from mpn-glaptop ([2620:0:105f:301:2ddc:c978:be37:615e]) by mx.google.com with ESMTPSA id a4sm31593139eez.0.2013.06.24.15.35.37 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Mon, 24 Jun 2013 15:35:38 -0700 (PDT) In-Reply-To: <51C8B2AF.2090409@gmx.at> User-Agent: Notmuch/0.15.2+55~geb6e9d8 (http://notmuchmail.org) Emacs/24.3.50.1 (x86_64-unknown-linux-gnu) X-Face: PbkBB1w#)bOqd`iCe"Ds{e+!C7`pkC9a|f)Qo^BMQvy\q5x3?vDQJeN(DS?|-^$uMti[3D*#^_Ts"pU$jBQLq~Ud6iNwAw_r_o_4]|JO?]}P_}Nc&"p#D(ZgUb4uCNPe7~a[DbPG0T~!&c.y$Ur,=N4RT>]dNpd; KFrfMCylc}gc??'U2j,!8%xdD Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAJFBMVEWbfGlUPDDHgE57V0jUupKjgIObY0PLrom9mH4dFRK4gmjPs41MxjOgAAACQElEQVQ4jW3TMWvbQBQHcBk1xE6WyALX1069oZBMlq+ouUwpEQQ6uRjttkWP4CmBgGM0BQLBdPFZYPsyFUo6uEtKDQ7oy/U96XR2Ux8ehH/89Z6enqxBcS7Lg81jmSuujrfCZcLI/TYYvbGj+jbgFpHJ/bqQAUISj8iLyu4LuFHJTosxsucO4jSDNE0Hq3hwK/ceQ5sx97b8LcUDsILfk+ovHkOIsMbBfg43VuQ5Ln9YAGCkUdKJoXR9EclFBhixy3EGVz1K6eEkhxCAkeMMnqoAhAKwhoUJkDrCqvbecaYINlFKSRS1i12VKH1XpUd4qxL876EkMcDvHj3s5RBajHHMlA5iK32e0C7VgG0RlzFPvoYHZLRmAC0BmNcBruhkE0KsMsbEc62ZwUJDxWUdMsMhVqovoT96i/DnX/ASvz/6hbCabELLk/6FF/8PNpPCGqcZTGFcBhhAaZZDbQPaAB3+KrWWy2XgbYDNIinkdWAFcCpraDE/knwe5DBqGmgzESl1p2E4MWAz0VUPgYYzmfWb9yS4vCvgsxJriNTHoIBz5YteBvg+VGISQWUqhMiByPIPpygeDBE6elD973xWwKkEiHZAHKjhuPsFnBuArrzxtakRcISv+XMIPl4aGBUJm8Emk7qBYU8IlgNEIpiJhk/No24jHwkKTFHDWfPniR 4iw5vJaw2nzSjfq2zffcE/GDjRC2dn0J0XwPAbDL84TvaFCJEU4Oml9pRyEUhR3Cl2t01AoEjRbs0sYugp14/4X5n4pU4EHHnMAAAAAElFTkSuQmCC X-PGP: 50751FF4 X-PGP-FP: AC1F 5F5C D418 88F8 CC84 5858 2060 4012 5075 1FF4 X-Hashcash: 1:20:130624:emacs-devel@gnu.org::dZcwoQQlFREUiWSu:0000000000000000000000000000000000000000001cH2 X-Hashcash: 1:20:130624:monnier@iro.umontreal.ca::NHy6gpTBoMbM444r:00000000000000000000000000000000000007m84 X-Hashcash: 1:20:130624:rudalics@gmx.at::tlxkMe9ywwcAX6Ju:00G15N X-Gm-Message-State: ALoCoQkfuhExlwiVLcNsWVwVFCCJhbiB1U7VbxPqKbOWtQ9/hEVR9wPxFYhJ2nrJgkIoCvpZZg2Uo1NvhAN4RJmHfCI9H6YaL7agv/Fmyo2hCjPmpr/+VEtk3F9iUP2qTHE3NVn6/n2JvOjiN0avsempwwh+KTRSPhCG7GgtVY90EAaG4VBQmpFoBhtuG4TA48KORcuJDi/hh9WtjA/bTWRRtSjBXZdkzg== X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4013:c00::229 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:160991 Archived-At: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Mon, Jun 24 2013, martin rudalics wrote: > Sure. What I meant is that `kill-buffer' should return immediately when > the buffer is dead after calling the query functions instead of entering > the do_yes_or_no_p stuff with a dead buffer. Or did I miss something? Ah, right. Changing the=20 if (INTERACTIVE && !NILP (BVAR (b, filename)) && BUF_MODIFF (b) > BUF_SAVE_MODIFF (b)) condition to if (INTERACTIVE && BUFFER_LIVE_P (b) && !NILP (BVAR (b, filename)) && BUF_MODIFF (b) > BUF_SAVE_MODIFF (b)) would solve the issue. Either that or adding if (!BUFFER_LIVE_P (b)) return unbind_to (count, Qt); just prior to the whole if statement which has the side effect of not calling kill-buffer-hook if any of the kill-buffer-query-functions kills the buffer, which actually may be desired. --=20 Best regards, _ _ .o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o ..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz = (o o) ooo +------------------ooO--(_)--Ooo-- --=-=-= Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" --==-=-= Content-Type: text/plain --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBAgAGBQJRyMm0AAoJECBgQBJQdR/0qm8P/1UykCNLv+F0D6SDPhzjOQ/h US5T4frrd0pp84lGQ7IjnaFvlQfS8o8D9C9bgPZF9gMdnpHHvVTIJW5lS93Wgq8a HqDz6NRmnICTFlppga2bS8yTGtgWtIx8k/wxCDgy4Dz8HZnv1fnBIDkyx44CaItG NBZPCOre0tEg/udpilgZ5RsPNF0E3nDi6tLI6idB9QgVK+Bgrk9QZ5CuWS9lokke sfAOr8cwOxK5G65dXIpplThrs+kRxoIXlKX9X7S5+4tkifOMSKVRMb3AnWYNkPE5 gAWp1LcQ8vYpmC7uK5OyuxAc1OMWcPKfKQWpXC5MTGnSOsxYrMJPzz2SXWesPPzK UQmrr4JVy8V/vDCvlW9jNhMDEtduCubOikh2K1XKaQNtpVSyF2GgiP7IkOc8+pwg B2Ga2PXNC1aYzpPTR1L2I5MEa00ZwRqfafWF6pzfSGFzOOPO6mpsWXGfyRz2Xc4f 5KcoZNG3Q2lI4cPcxOjK3f8UJfoEb0AyW61CkP6qwi0PjG+q4lm5xTeDR6nDk1zy x8pcQ8gq2VmVjj79fjpcjDlXjG8yeixtztZcCyOmAe4SeLwILOLMW5Ujkef7YR1k szjUZSuPI5IDzkKxb7qRqbu/Fsp9sSFIwk8fvrWr9tCqRWTVkxlt67IDXfFQyAFc fLuuaMR+HKSO9y+Sfe/f =XX3U -----END PGP SIGNATURE----- --==-=-=-- --=-=-=--