unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Michal Nazarewicz <mina86@mina86.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org
Subject: Re: Sending multiple patches
Date: Tue, 03 Jun 2014 08:28:13 +0200	[thread overview]
Message-ID: <xa1t38fmld6q.fsf@mina86.com> (raw)
In-Reply-To: <jwv4n03ceq5.fsf-monnier+emacs@gnu.org>

>> The simplest would probably be to change the entity to numeric one even
>> in HTML, but I'm not sure if users would like it.

On Mon, Jun 02 2014, Stefan Monnier wrote:
> Indeed, I for one would be very disappointed to see &#160; instead of
> &nbsp; there.  Of course, I'd even prefer seeing " ".

Agreed, but that could create encoding issues for some users, therefore
I think it's better to leave it as entity reference and let users change
it to the non-break space character themselves.

>> I started implementing this which is when I realised that "end-\\1"
>> won't cut it because contents of the matched capture group must be
>> escaped with `regexp-quote'.  For example, if we had:

On Mon, Jun 02 2014, Stefan Monnier wrote:
> AFAICT, you can regexp-quote the whole result.

Unfortunately that is not the case.  For example, imagine a hypothetical
language where comments can be written as “<!-- … -->” or “<!== … ==>”
with optional spaces like in HTML.  Regex pair to match it would be:

    ("<! *\\(--\\|==\\)" . (1 " *>"))

If the code was changed so that the whole end-pattern is regexp-quote'd,
the asterisk would get escaped.

>> Good idea.  Do you think it'd be acceptable to completely drop support
>> for “("end-" 1)” and change the meaning of strings to be processed by
>> `replace-mach'?

> For the major-mode-set buffer-local variable, there'd be no backward
> compatibility issue, of course.

Let's leave it as is for now then, and bundle both changes together in
some way.

Do you think that adding Perl's \Q…\E support to `replace-match' would
make sense? For instance, we could than have:

    ("verb\\(.\\)" . "\\E\\1\\Q")

Or is tildify.el to small of a user to justify fiddling with
`replace-match'?

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michał “mina86” Nazarewicz    (o o)
ooo +--<mpn@google.com>--<xmpp:mina86@jabber.org>--ooO--(_)--Ooo--



  reply	other threads:[~2014-06-03  6:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-02  8:35 Sending multiple patches Michal Nazarewicz
2014-06-02 13:17 ` Stefan Monnier
2014-06-02 13:24   ` David Kastrup
2014-06-02 16:15     ` Stefan Monnier
2014-06-02 17:58       ` Yuri Khan
2014-06-02 15:47   ` Glenn Morris
2014-06-02 18:33   ` Michal Nazarewicz
2014-06-02 19:11     ` Stefan Monnier
2014-06-03  6:28       ` Michal Nazarewicz [this message]
2014-06-03 13:25         ` Stefan Monnier
2014-06-07 17:28           ` Michal Nazarewicz
2014-06-08  1:26             ` Stefan Monnier
2014-06-07 15:05         ` Herring, Davis
2014-06-02 19:03   ` Michal Nazarewicz
2014-06-03  0:00     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xa1t38fmld6q.fsf@mina86.com \
    --to=mina86@mina86.com \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).