From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: do-auto-fill bug? Date: 06 Jul 2004 09:29:28 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <78hdsmgflc.fsf@namazu.org> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1089098998 20299 80.91.224.253 (6 Jul 2004 07:29:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 6 Jul 2004 07:29:58 +0000 (UTC) Cc: Katsumi Yamaoka , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Jul 06 09:29:50 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BhkOk-000093-00 for ; Tue, 06 Jul 2004 09:29:50 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BhkOk-0004au-00 for ; Tue, 06 Jul 2004 09:29:50 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhkQk-0000Ok-R8 for emacs-devel@quimby.gnus.org; Tue, 06 Jul 2004 03:31:54 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BhkQd-0000OS-31 for emacs-devel@gnu.org; Tue, 06 Jul 2004 03:31:47 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BhkQc-0000O0-JC for emacs-devel@gnu.org; Tue, 06 Jul 2004 03:31:46 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BhkQc-0000No-GP for emacs-devel@gnu.org; Tue, 06 Jul 2004 03:31:46 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BhkOU-0007RF-0q for emacs-devel@gnu.org; Tue, 06 Jul 2004 03:29:34 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1BhkOS-00084t-Nl; Tue, 06 Jul 2004 03:29:33 -0400 Original-To: Stefan In-Reply-To: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50 Original-Lines: 63 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25467 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25467 Stefan writes: > > I sent a bug report to the pretest-bug list toward the end of > > May, however there is no response so far. Is no one being > > troubled with the problem? The patch I included in the report > > seems to have no problem so far, and I hope it will be applied. > > I've taken a quick look a while back but haven't had the time to come up > with a good bugfix yet. Maybe your patch (improved to also prevent > breaking in front of "[ \t]*$") is good enough, I failed to followup on the following posting on emacs-pretest-bug. Maybe one of the fixes is better than the other? From: Richard Stallman To: David Kastrup CC: emacs-pretest-bug@gnu.org Subject: Re: auto-fill-mode and filling paragraphs differ References: Message-Id: Date: Fri, 02 Apr 2004 01:01:12 -0500 I would interpret this as the last permissable column of content. According to C-x =, column 70 is the column _after_ fsafd. If we now say "ok, at this column, the end of line is legal", it would appear that auto-fill-mode wraps one column too early. I think that typing a space immediately at the end of line should _not_ wrap the preceding word to the next line, but merely replace the typed space (instead of the last space before that) with a newline. I agree with you. Does this patch give correct results? *** fill.el.~1.170.~ Fri Mar 26 12:04:37 2004 --- fill.el Thu Apr 1 23:12:54 2004 *************** *** 353,359 **** ;; Don't split a line if the rest would look like a new paragraph. (unless use-hard-newlines (save-excursion ! (skip-chars-forward " \t") (looking-at paragraph-start))) (run-hook-with-args-until-success 'fill-nobreak-predicate))))) ;; Put `fill-find-break-point-function' property to charsets which --- 353,364 ---- ;; Don't split a line if the rest would look like a new paragraph. (unless use-hard-newlines (save-excursion ! (skip-chars-forward " \t") ! ;; If this break point is at the end of the line, ! ;; which can occur for auto-fill, don't consider the newline ! ;; which follows as a reason to return t. ! (and (not (eolp)) ! (looking-at paragraph-start)))) (run-hook-with-args-until-success 'fill-nobreak-predicate))))) ;; Put `fill-find-break-point-function' property to charsets which -- David Kastrup, Kriemhildstr. 15, 44793 Bochum