From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Another bug with the macro counter Date: Sat, 30 Oct 2004 20:06:53 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: <200410210107.i9L176B10842@raven.dms.auburn.edu> <200410300238.i9U2cOD02290@raven.dms.auburn.edu> <200410300327.i9U3RWW02355@raven.dms.auburn.edu> <200410301419.i9UEJr002854@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099159656 15291 80.91.229.6 (30 Oct 2004 18:07:36 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 30 Oct 2004 18:07:36 +0000 (UTC) Cc: Luc Teirlinck , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 30 20:07:23 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CNxdK-0008Dv-00 for ; Sat, 30 Oct 2004 20:07:22 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CNxlF-0008HY-5J for ged-emacs-devel@m.gmane.org; Sat, 30 Oct 2004 14:15:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CNxl1-0008Gj-3O for emacs-devel@gnu.org; Sat, 30 Oct 2004 14:15:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CNxl0-0008GP-GE for emacs-devel@gnu.org; Sat, 30 Oct 2004 14:15:18 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CNxl0-0008GE-7t for emacs-devel@gnu.org; Sat, 30 Oct 2004 14:15:18 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CNxcs-0004Gn-BO for emacs-devel@gnu.org; Sat, 30 Oct 2004 14:06:54 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1CNxbv-0000IG-J1; Sat, 30 Oct 2004 14:05:55 -0400 Original-To: Stefan In-Reply-To: (Stefan's message of "Sat, 30 Oct 2004 12:12:57 -0400") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29183 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29183 Stefan writes: >> + ;; Quiet the compiler. >> + (defvar edebug-active) >> + > > I'm not sure this is right. I think such defvars should only be put when we > know from circumstancial evidence (that the byte-compiler does not have > access to) that the variable will be available. If we need to check with > `boundp', I find it's better not to put a `defvar' (and to rely on the (if > (boundp 'foo) foo) form recognized by the byte-compiler). Quieting the byte compiler can probably also be achieved with (eval-when-compile (defvar edebug-active)) -- David Kastrup, Kriemhildstr. 15, 44793 Bochum