From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: Is that change a good idea? Date: Fri, 18 Mar 2005 15:07:07 +0100 Message-ID: References: <20050318082442.GA4710@kenny.sha-bang.local> <871xad5b2j.fsf-monnier+emacs@gnu.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1111154952 24408 80.91.229.2 (18 Mar 2005 14:09:12 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2005 14:09:12 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Mar 18 15:09:12 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1DCI8e-00016E-Op for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2005 15:07:50 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DCIP9-0002G7-Qr for ged-emacs-devel@m.gmane.org; Fri, 18 Mar 2005 09:24:47 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DCIOQ-00024k-5t for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:24:02 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DCION-00023X-0r for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:23:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DCIOM-00021L-0H for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:23:58 -0500 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DCI89-0000Tl-4X for emacs-devel@gnu.org; Fri, 18 Mar 2005 09:07:13 -0500 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1DCI88-0006fM-H7; Fri, 18 Mar 2005 09:07:12 -0500 Original-To: Stefan Monnier In-Reply-To: <871xad5b2j.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 18 Mar 2005 08:45:49 -0500") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org X-MailScanner-To: ged-emacs-devel@m.gmane.org Xref: news.gmane.org gmane.emacs.devel:34722 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:34722 Stefan Monnier writes: >>> > * help.el (describe-mode): Allow a :minor-mode-function property to >>> > specify a different minor mode toggle function than the variable. >>> > * simple.el (auto-fill-function): >>> > * subr.el (add-minor-mode): Use it. >>> >>> > I have my doubts that the resulting flexibility is really in the best >>> > interest of the users... >>> >>> 100% agreement. >>> It's only meant to clean up the code, > >> Wouldn't it be far more cleaner to convert old minor-modes which would >> need this hack to proper minor-modes following standard semantics? > > You do realize that there are packages over which we have no > control, right? Well, then we won't need to worry about us not being able to use define-minor-mode for them. > make sure they're kept in sync. Maybe we could do (defvaralias > 'auto-fill-function 'auto-fill-mode) and then slowly change modes to > replace (if auto-fill-function (funcall auto-fill-function)) with > (if auto-fill-mode (funcall normal-auto-fill-function)). That won't work if modes set auto-fill-function themselves to a function... -- David Kastrup, Kriemhildstr. 15, 44793 Bochum