unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
Cc: reiner.steib@gmx.de, emacs-devel@gnu.org
Subject: Re: All platforms fail with Unicode in menus.
Date: 28 Aug 2004 09:11:21 +0200	[thread overview]
Message-ID: <x5eklrspnq.fsf@lola.goethe.zz> (raw)
In-Reply-To: <412E2C34.8070905@swipnet.se>

"Jan D." <jan.h.d@swipnet.se> writes:

> David Kastrup wrote:
> 
> > The best contender right now is GTK which gets it right, except that
> > it completely garbles the menus when garbage collection occurs during
> > their creation (the gc-cons-threshold setting at the end of this
> > example file more or less ensures that stuff gets garbled).
> 
> It seems that the string returned by ENCODE_UTF_8 gets collected during GC,
> resulting in passing garbage to the GTK menu code.
> 
> I can work around the bug by this patch (the call to
> inhibit_garbage_collection is present in macmenu.c), but I am not sure
> it is the correct way to fix this:

> +       inhibit_garbage_collection ();

> Can someone that knows ENCODE_UTF_8 and garbage collection well
> comment on this patch?

I don't know either well, but of course that is not the correct way to
fix it.  The correct way would be to add appropriate GCPRO and UNGCPRO
calls for temporary data structures that should not yet be collected.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2004-08-28  7:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-25 21:48 All platforms fail with Unicode in menus David Kastrup
2004-08-26  8:13 ` YAMAMOTO Mitsuharu
2004-08-26 18:30 ` Jan D.
2004-08-28  7:11   ` David Kastrup [this message]
2004-08-28  7:42     ` Jan D.
2004-08-28  8:08       ` David Kastrup
2004-08-28  8:24         ` Andreas Schwab
2004-08-28 21:38     ` Stefan
2004-08-28 22:18       ` Jan D.
2004-08-28 22:38         ` Stefan
2004-08-30  7:52   ` YAMAMOTO Mitsuharu
2004-08-30 10:28     ` Jan D.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x5eklrspnq.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=reiner.steib@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).