From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.emacs.devel Subject: Re: simple patch for `align.el' Date: Sun, 24 Oct 2004 09:15:53 +0200 Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1098602195 8552 80.91.229.6 (24 Oct 2004 07:16:35 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 24 Oct 2004 07:16:35 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Oct 24 09:16:31 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CLccA-0004fc-00 for ; Sun, 24 Oct 2004 09:16:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLcjk-0001fC-TT for ged-emacs-devel@m.gmane.org; Sun, 24 Oct 2004 03:24:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CLcja-0001f6-Dc for emacs-devel@gnu.org; Sun, 24 Oct 2004 03:24:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CLcja-0001eu-0N for emacs-devel@gnu.org; Sun, 24 Oct 2004 03:24:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CLcjZ-0001er-Sq for emacs-devel@gnu.org; Sun, 24 Oct 2004 03:24:09 -0400 Original-Received: from [199.232.76.164] (helo=fencepost.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CLcbZ-00059f-Pa for emacs-devel@gnu.org; Sun, 24 Oct 2004 03:15:53 -0400 Original-Received: from localhost ([127.0.0.1] helo=lola.goethe.zz) by fencepost.gnu.org with esmtp (Exim 4.34) id 1CLcbJ-0003Ea-Cr; Sun, 24 Oct 2004 03:15:37 -0400 Original-To: John Wiegley In-Reply-To: (John Wiegley's message of "Sat, 23 Oct 2004 17:17:06 -0700") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/21.3.50 (gnu/linux) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:28817 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:28817 John Wiegley writes: > Paul Pogonyshev writes: > >> then select this region and `M-x align' it. The first line will >> have a space followed by a tab, which is not good and is frowned >> upon by the `whitespace' module. The simple patch below fixes this. > > The patch looks fine enough to me. Just take care that the deletion > does not adversely affect any markers. I remember having lots of > subtle bugs with that in the past. Good point. The easiest way to do that is to _first_ insert the tab, then remove the spaces. -- David Kastrup, Kriemhildstr. 15, 44793 Bochum