unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: replace.el changes...
Date: 21 Jun 2004 17:10:01 +0200	[thread overview]
Message-ID: <x5659leyly.fsf@lola.goethe.zz> (raw)
In-Reply-To: <87llihotdc.fsf@mail.jurta.org>

Juri Linkov <juri@jurta.org> writes:

> David Kastrup <dak@gnu.org> writes:
> > If a replacement has already been done, the stored information in the
> > history does not contain the highlighted region.  So I am going to
> > have to either change the history information format, or don't enter
> > actually performed replacements into that list for revisiting in the
> > first place, or don't highlight things when going backwards in the
> > list.  Incidentally, the history is also the return value from all
> > replacement commands: anybody know whether this is actually used
> > anywhere?
> 
> I don't know where it is used, but I think it's better not to change
> the format of the return value.

It is actually not documented to be useful, except as being nil or
non-nil.  And even then, it is only documented for perform-replace
itself (the internal routine doing the job).  AFAICS, the return value
from perform-replace is actually used nowhere within Emacs directly
_except_ for incidentally also being the return value of all
replacement-related functions.  Searching for uses of all of them
would be work...

> You could remove your additional fields from the history before
> returning it.

Sounds like overkill for something that is not even documented to be
useful.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2004-06-21 15:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-21 14:05 replace.el changes David Kastrup
2004-06-21 14:55 ` Juri Linkov
2004-06-21 15:10   ` David Kastrup [this message]
2004-06-22  9:48     ` Juri Linkov
2004-06-22  9:55       ` David Kastrup
2004-06-22 23:16     ` Richard Stallman
2004-06-22 23:36       ` David Kastrup
2004-06-24 23:48         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x5659leyly.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).