M-x compile should tell its status (a little bit better)..

M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi.

Right know when starting compile it shows "Compiling" in the mode line.
When i started several compilations in parallel i found it confusing that
i could not find out if one of them has already finished. Execpt by
switching to that buffer and looking at its mode line...
So how about to change compile to reflect that info in its mode name so
that C-x C-b could show it like it it does for dired? (dired by name/dired
by date). Maybe the same thing should be done for M-x shell, M-x term, M-x
grep and similar modes?
What do others think about this?
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    Right know when starting compile it shows "Compiling" in the mode line.
    When i started several compilations in parallel i found it confusing that
    i could not find out if one of them has already finished. Execpt by
    switching to that buffer and looking at its mode line...
    So how about to change compile to reflect that info in its mode name so

Could you say more precisely what change you have in mind
in the mode line contents?

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi.

Richard Stallman <rms@gnu.org> writes:

>     Right know when starting compile it shows "Compiling" in the mode line.
>     When i started several compilations in parallel i found it confusing that
>     i could not find out if one of them has already finished. Execpt by
>     switching to that buffer and looking at its mode line...
>     So how about to change compile to reflect that info in its mode name so
> 
> Could you say more precisely what change you have in mind
> in the mode line contents?

Yes of course. The change to the mode line would however just be a
side effect..

C-x C-b (list-buffers)
currently shows something like this:

 MR Buffer           Size  Mode         File
 -- ------           ----  ----         ----
. % ~		     2485  Dired by name ~/
. % /		     2485  Dired by date /
 *  *compilation*     142  Compilation	
 *  *compilation*<2>  142  Compilation	
 *  *compilation*<3>  476  Compilation	
 *  *compilation*<4> 1892  Compilation	


My idea is to change it like this:

 MR Buffer           Size  Mode         File
 -- ------           ----  ----         ----
. % ~		     2485  Dired by name ~/
. % /		     2485  Dired by date /
 *  *compilation*     142  Compile running	
 *  *compilation*<2>  142  Compile ok	
 *  *compilation*<3>  476  Compile ok	
 *  *compilation*<4> 1892  Compile aborted	

Just the way dired show if it sorts by name oder by date could be used
by M-x compile to show if it is still running or if it finished
with/without errors. I think things like M-x grep, M-x shell-command
would also benefit from such an aproach..

I think visual feetback is very important and this seems like just a
little change (for the better) since compile already set the
"Compiling" string in the modeline..

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    My idea is to change it like this:

     MR Buffer           Size  Mode         File
     -- ------           ----  ----         ----
    . % ~		     2485  Dired by name ~/
    . % /		     2485  Dired by date /
     *  *compilation*     142  Compile running	
     *  *compilation*<2>  142  Compile ok	
     *  *compilation*<3>  476  Compile ok	
     *  *compilation*<4> 1892  Compile aborted	

It seems ok to me.

Re: M-x compile should tell its status (a little bit better)..

[Kevin Rodgers]

Richard Stallman wrote:

>     Right know when starting compile it shows "Compiling" in the mode line.
>     When i started several compilations in parallel i found it confusing that
>     i could not find out if one of them has already finished. Execpt by
>     switching to that buffer and looking at its mode line...
>     So how about to change compile to reflect that info in its mode name so
> 
> Could you say more precisely what change you have in mind
> in the mode line contents?

I think the idea is not to change the mode line, but to change the mode name

so that the status is apparent from `M-x list-buffers'.  I think the following
provides the desired effect, but it's just for illustration:


(defvar compilation-mode-name nil)

;; change `after' to `before', to avoid stomping on compilation-handle-exit:
(defadvice compilation-sentinel (after mode-name activate)
   "Set `mode-name' instead of `mode-line-process' to reflect the PROCess status."
   (let ((buffer (process-buffer (ad-get-arg 0)))
	(status (process-status (ad-get-arg 0))))
     (when (buffer-live-p buffer)
       (save-excursion
	(set-buffer buffer)
	;; save the original mode name:
	(unless compilation-mode-name
	  (set (make-local-variable 'compilation-mode-name) mode-name))
	;; construct a mode name from the original plus the status:
	(setq mode-name
	      (format "%s:%s)" compilation-mode-name status))
	;; remove redundant status from the mode line:
	(setq mode-line-process nil)))))

(defadvice compile-internal (after compilation-sentinel activate)
   "Call `compilation-sentinel' to set `mode-name'."
   (compilation-sentinel (get-buffer-process compilation-last-buffer)
			"started"))

-- 
Kevin Rodgers

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> Richard Stallman wrote:
> 
> > Could you say more precisely what change you have in mind in the
> > mode line contents?
> 
> I think the idea is not to change the mode line, but to change the
> mode name so that the status is apparent from `M-x list-buffers'.  I
> think the following provides the desired effect, but it's just for
> illustration:

Yes that was my idea. I hope my example in an earlier mail was also
helpful to understand what i had in mind.

Do you think such a change would be good? And which other modes could
benefit from such a visual feedback? Maybe all modes that use an
(longrunning) inferior process..

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Kevin Rodgers]

Stephan Stahl wrote:
 > Kevin Rodgers <ihs_4664@yahoo.com> writes:
 >>Richard Stallman wrote:
 >>>Could you say more precisely what change you have in mind in the
 >>>mode line contents?
 >>>
 >>I think the idea is not to change the mode line, but to change the
 >>mode name so that the status is apparent from `M-x list-buffers'.  I
 >>think the following provides the desired effect, but it's just for
 >>illustration:
 >
 > Yes that was my idea. I hope my example in an earlier mail was also
 > helpful to understand what i had in mind.
 >
 > Do you think such a change would be good? And which other modes could
 > benefit from such a visual feedback? Maybe all modes that use an
 > (longrunning) inferior process..

I think a better change would be to include mode-line-process in the
*Buffer List* buffer:


2004-04-27  Kevin Rodgers  <ihs_4664@yahoo.com>

	* buff-menu.el (list-buffers-noselect): Append the buffer's
	  process status to its mode name.


*** emacs-21.3/lisp/buff-menu.el.orig	Wed Aug 29 08:53:31 2001
--- emacs-21.3/lisp/buff-menu.el	Tue Apr 27 10:38:25 2004
***************
*** 503,512 ****
                 this-buffer-read-only
                 (this-buffer-size (buffer-size buffer))
                 this-buffer-mode-name
                 this-buffer-directory)
             (with-current-buffer buffer
!             (setq this-buffer-read-only buffer-read-only
!                   this-buffer-mode-name mode-name)
               (unless file
                 ;; No visited file.  Check local value of
                 ;; list-buffers-directory.
--- 503,523 ----
                 this-buffer-read-only
                 (this-buffer-size (buffer-size buffer))
                 this-buffer-mode-name
+               (this-buffer-process (get-buffer-process buffer))
                 this-buffer-directory)
             (with-current-buffer buffer
!             (setq this-buffer-read-only buffer-read-only)
!             (setq this-buffer-mode-name
!                   (concat mode-name
!                           ;; is there a way to convert an arbitrary
!                           ;; mode-line-format element to a string?
!                           (cond ((stringp mode-line-process)
!                                  mode-line-process)
!                                 (this-buffer-process ; emulate (":%s")
!                                  (concat ":"
!                                          (symbol-name
!                                           (process-status
!                                            this-buffer-process)))))))
               (unless file
                 ;; No visited file.  Check local value of
                 ;; list-buffers-directory.

-- 
Kevin Rodgers

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi.

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> I think a better change would be to include mode-line-process in the
> *Buffer List* buffer:

I could not test it until now..
I think that would be a great change. Really like it.
If people think it would be good to have i could adapt the change to
the current buff-menu.el which has changed quite a bit since 21.3 over
the weekend ?

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Stefan Monnier]

>> I think a better change would be to include mode-line-process in the
>> *Buffer List* buffer:

Agreed.


        Stefan

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi Kevin.

Kevin Rodgers <ihs_4664@yahoo.com> writes:

> I think a better change would be to include mode-line-process in the
> *Buffer List* buffer:
> 
> 
> 2004-04-27  Kevin Rodgers  <ihs_4664@yahoo.com>
> 
> 	* buff-menu.el (list-buffers-noselect): Append the buffer's
> 	  process status to its mode name.

I tried to "port" your change to cvs emacs. I really like this
addition so maybe someone wants to include it in cvs emacs.

diff -c buff-menu.el.\~1.66.\~ buff-menu.el
*** buff-menu.el.~1.66.~	Thu Apr  1 03:23:36 2004
--- buff-menu.el	Sun Jul 11 03:37:11 2004
***************
*** 613,619 ****
  			 "  "
  			 (Buffer-menu-make-sort-button "Mode" 4) mode-end
  			 (Buffer-menu-make-sort-button "File" 5) "\n"))
! 	 list desired-point name file)
      (when Buffer-menu-use-header-line
        (let ((pos 0))
  	;; Turn spaces in the header into stretch specs so they work
--- 613,619 ----
  			 "  "
  			 (Buffer-menu-make-sort-button "Mode" 4) mode-end
  			 (Buffer-menu-make-sort-button "File" 5) "\n"))
! 	 list desired-point name process mode file)
      (when Buffer-menu-use-header-line
        (let ((pos 0))
  	;; Turn spaces in the header into stretch specs so they work
***************
*** 639,645 ****
  		   (lambda (buffer)
  		     (with-current-buffer buffer
  		       (setq name (buffer-name)
! 			     file (buffer-file-name))
  		       (cond
  			;; Don't mention internal buffers.
  			((and (string= (substring name 0 1) " ") (null file)))
--- 639,657 ----
  		   (lambda (buffer)
  		     (with-current-buffer buffer
  		       (setq name (buffer-name)
! 			     process (get-buffer-process buffer)
! 			     mode (concat mode-name
! 					  ;; is there a way to convert
! 					  ;; an arbitrary mode-line-format
! 					  ;; element to a string?
! 					  (cond ((stringp mode-line-process)
! 						 mode-line-process)
! 						(process ; emulate (":%s")
! 						 (concat ":"
! 							 (symbol-name
! 							  (process-status
! 							   process))))))
! 		       file (buffer-file-name))
  		       (cond
  			;; Don't mention internal buffers.
  			((and (string= (substring name 0 1) " ") (null file)))
***************
*** 665,671 ****
  					   ?% ? )
  				       ;; Identify modified buffers.
  				       (if (buffer-modified-p) ?* ? ))
! 			       name (buffer-size) mode-name file)))))
  		   (buffer-list))))
        (dolist (buffer
  	       (if Buffer-menu-sort-column
--- 677,683 ----
  					   ?% ? )
  				       ;; Identify modified buffers.
  				       (if (buffer-modified-p) ?* ? ))
! 			       name (buffer-size) mode file)))))
  		   (buffer-list))))
        (dolist (buffer
  	       (if Buffer-menu-sort-column

-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi Richard. (I've CC'ed emacs-devel again because of this possible bug..)

I said:

> Here is a new patch. With the funtion you suggested it is much simpler.
> diff -c buff-menu.el.\~1.66.\~ buff-menu.el
> *** buff-menu.el.\~1.66.\~ Mon Jul 12 11:01:15 2004
> --- buff-menu.el Mon Jul 12 11:08:58 2004
> ***************
> *** 613,619 ****
>   			 "  "
>   			 (Buffer-menu-make-sort-button "Mode" 4) mode-end
>   			 (Buffer-menu-make-sort-button "File" 5) "\n"))
> ! 	 list desired-point name file)
>       (when Buffer-menu-use-header-line
>         (let ((pos 0))
>   	;; Turn spaces in the header into stretch specs so they work
> --- 613,619 ----
>   			 "  "
>   			 (Buffer-menu-make-sort-button "Mode" 4) mode-end
>   			 (Buffer-menu-make-sort-button "File" 5) "\n"))
> ! 	 list desired-point name mode file)
>       (when Buffer-menu-use-header-line
>         (let ((pos 0))
>   	;; Turn spaces in the header into stretch specs so they work
> ***************
> *** 639,644 ****
> --- 639,647 ----
>   		   (lambda (buffer)
>   		     (with-current-buffer buffer
>   		       (setq name (buffer-name)
> + 			     mode (concat mode-name
> + 					  (if mode-line-process
> + 					      (format-mode-line mode-line-process)))
>   			     file (buffer-file-name))
>   		       (cond
>   			;; Don't mention internal buffers.
> ***************
> *** 665,671 ****
>   					   ?% ? )
>   				       ;; Identify modified buffers.
>   				       (if (buffer-modified-p) ?* ? ))
> ! 			       name (buffer-size) mode-name file)))))
>   		   (buffer-list))))
>         (dolist (buffer
>   	       (if Buffer-menu-sort-column
> --- 668,674 ----
>   					   ?% ? )
>   				       ;; Identify modified buffers.
>   				       (if (buffer-modified-p) ?* ? ))
> ! 			       name (buffer-size) mode file)))))
>   		   (buffer-list))))
>         (dolist (buffer
>   	       (if Buffer-menu-sort-column

It does however not work correctly.. I suspect format-mode-line to be guilty but have
not yet looked at the c code..

format-mode-line returns different things depending on the buffer it was called from.

With this example the bug can be seen to.

emacs -q --no-site-init
M-x shell
M-; (with-current-buffer (get-buffer "*shell*")
  (concat mode-name
	  (if mode-line-process
	      (format-mode-line mode-line-process))))
=> "Shell:run"

C-x C-b <RET>   (you should be in *scratch* now)
M-; (with-current-buffer (get-buffer "*shell*")
  (concat mode-name
	  (if mode-line-process
	      (format-mode-line mode-line-process))))
=> "Shell:no process"

Maybe someone can help me with this??

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Stefan Monnier]

> + 			     mode (concat mode-name
> + 					  (if mode-line-process
> + 					      (format-mode-line mode-line-process)))

BTW, `mode-name' should go through format-mode-line as well.


        Stefan

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    BTW, `mode-name' should go through format-mode-line as well.

This would do no harm, but mode-name is always supposed to be a string.

Re: M-x compile should tell its status (a little bit better)..

[David Kastrup]

Richard Stallman <rms@gnu.org> writes:

>     BTW, `mode-name' should go through format-mode-line as well.
> 
> This would do no harm, but mode-name is always supposed to be a string.

Oooh.  I am moping because in AUCTeX, I was thinking of having a few
"flags" attached to the mode-name, so that I can have a mode-name
something like

'((TeX-use-pdftex "PDF") TeX-base-mode-name (TeX-source-specials "^"))

where the actual name is automatically composed from a few `lighters'
that would look pretty foolish anywhere else.

So maybe I need to hand-construct mode-name after all.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi David.

David Kastrup said:

> Richard Stallman <rms@gnu.org> writes:
>
>> This would do no harm, but mode-name is always supposed to be a string.
>
> Oooh.  I am moping because in AUCTeX, I was thinking of having a few
> "flags" attached to the mode-name, so that I can have a mode-name
> something like
>
> '((TeX-use-pdftex "PDF") TeX-base-mode-name (TeX-source-specials "^"))
>
> where the actual name is automatically composed from a few `lighters'
> that would look pretty foolish anywhere else.
>
> So may be I need to hand-construct mode-name after all.

I have seen that cc-mode has something similar. (c-toggle-hungry-state and
c-toggle-auto-state). It adds /h or /a or /ah to the mode name if they are
activated. It does so by adding

 (c-auto-hungry-string c-auto-hungry-string)

to minor-mode-alist. I think AUCTeX could do the same?

Well actually the docs to cc-mode are not 100% correct. It says:

   The state of the minor modes is always reflected in the minor mode
list on the modeline of the CC Mode buffer.  When auto-newline mode is
enabled, you will see `C/a' on the mode line(1).  When hungry delete
mode is enabled you will see `C/h' and if both modes were enabled, you'd
see `C/ah'.

I do however NOT see 'C/ah' in the mode line but 'C Outl o^o/ah'. cc-mode
should maybe append (c-auto-hungry-string c-auto-hungry-string) to the
front of minor-mode-alist? Then it would look like the docs say..

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[David Kastrup]

"Stephan Stahl" <stahl@eos.franken.de> writes:

> David Kastrup said:
> 
> > Richard Stallman <rms@gnu.org> writes:
> >
> >> This would do no harm, but mode-name is always supposed to be a string.
> >
> > Oooh.  I am moping because in AUCTeX, I was thinking of having a few
> > "flags" attached to the mode-name, so that I can have a mode-name
> > something like
> >
> > '((TeX-use-pdftex "PDF") TeX-base-mode-name (TeX-source-specials "^"))
> >
> > where the actual name is automatically composed from a few `lighters'
> > that would look pretty foolish anywhere else.
> >
> > So may be I need to hand-construct mode-name after all.
> 
> I have seen that cc-mode has something similar. (c-toggle-hungry-state and
> c-toggle-auto-state). It adds /h or /a or /ah to the mode name if they are
> activated. It does so by adding
> 
>  (c-auto-hungry-string c-auto-hungry-string)
> 
> to minor-mode-alist. I think AUCTeX could do the same?

The problem is that, say, RefTeX minor mode gets started within
LaTeX-mode-hook (which means at a later time) and adds its " Ref"
lighter to the front of minor-mode-alist, before the "^" lighter.
Which looks stupid.  And anyway, minor-mode-alist will not let me add
a lighter in front, and the "PDFTeX" executable naming would make
that the best choice.

> Well actually the docs to cc-mode are not 100% correct. It says:
> 
>    The state of the minor modes is always reflected in the minor mode
> list on the modeline of the CC Mode buffer.  When auto-newline mode is
> enabled, you will see `C/a' on the mode line(1).  When hungry delete
> mode is enabled you will see `C/h' and if both modes were enabled, you'd
> see `C/ah'.
> 
> I do however NOT see 'C/ah' in the mode line but 'C Outl o^o/ah'. cc-mode
> should maybe append (c-auto-hungry-string c-auto-hungry-string) to the
> front of minor-mode-alist? Then it would look like the docs say..

That's what I mean.  cc-mode _will_ probably add this to the front of
minor-mode-alist, but other modes add to the list afterwards.  One
could reshuffle the list at strategic times, but frankly, it might be
easier just to fiddle with mode-name itself.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

Re: M-x compile should tell its status (a little bit better)..

[Stephan Stahl]

Hi David.

David Kastrup said:

> That's what I mean.  cc-mode _will_ probably add this to the front of
> minor-mode-alist, but other modes add to the list afterwards.  One
> could reshuffle the list at strategic times, but frankly, it might be
> easier just to fiddle with mode-name itself.

Yes you are right. CC-mode does add to the front of minor-mode-alist as do
the others.. at a later time. Thats why the order is not "right" for me.

I have a idea but i'm not sure how stupid it is :)

Currently mode-line-modes is something like this (simplified)
(...
 mode-name
 mode-line-process
 minor-mode-alist
 ...)

It could be changed to
(...
 mode-name
 helper-modes
 mode-line-process
 minor-mode-alist
 ...)

c-toggle-auto-state, c-toggle-hungry-state are really just helper modes
that are useless as single minor modes (outside the cc-mode context). I
suppose that same goes for the lighters you want to add to AUCTeX. All
those modes would than add to helper-modes and not to minor-mode-alist.

The variable helper-modes would then (more or less) be under the control
of the current major mode which will make it easy to keep it "right".

Just a idea..

Stephan
-- 
Stephan Stahl

Re: M-x compile should tell its status (a little bit better)..

[Kim F. Storm]

"Stephan Stahl" <stahl@eos.franken.de> writes:

> 
> I have a idea but i'm not sure how stupid it is :)

I think it is a great idea.

> 
> It could be changed to
> (...
>  mode-name
>  helper-modes
>  mode-line-process
>  minor-mode-alist
>  ...)
> 

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    I have a idea but i'm not sure how stupid it is :)

    Currently mode-line-modes is something like this (simplified)

The idea isn't stupid, but this is the wrong time for it.
Now we are trying to focus on fixing up what needs fixing
so we can make a release.  This doesn't need to be changed,
so let's not spend time on it now.

Re: M-x compile should tell its status (a little bit better)..

[Stefan]

>     BTW, `mode-name' should go through format-mode-line as well.
> This would do no harm, but mode-name is always supposed to be a string.

Why?
I haven't installed it in CVS, but in my local tree, html-mode's
`mode-name' is (sgml-xml-mode "XHTML" "HTML") so the mode name is
automatically kept in sync with the sgml-xml-mode minor mode.
It seems to work fine.


        Stefan

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    > This would do no harm, but mode-name is always supposed to be a string.

    Why?

That's how it's defined and documented to be used.
Maybe after the release we could consider whether it is
a good idea to change this.  For now, let's focus
on what needs to be done to make a good release.

Re: M-x compile should tell its status (a little bit better)..

[Richard Stallman]

    I think the idea is not to change the mode line, but to change the mode name

Setting mode-name is ok to do, since Dired does it.