unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: David Kastrup <dak@gnu.org>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: isearch-query-replace-regexp and stuff
Date: 07 Jul 2004 21:33:27 +0200	[thread overview]
Message-ID: <x51xjnk3y0.fsf@lola.goethe.zz> (raw)
In-Reply-To: <87vfgz4qn3.fsf@mail.jurta.org>

Juri Linkov <juri@jurta.org> writes:

> David Kastrup <dak@gnu.org> writes:
> > Juri Linkov <juri@jurta.org> writes:
> >> The current behavior of C-M-s to repeat the non-regexp search is not
> >> the most reasonable one.  More correct would be to switch the search
> >> to regexp mode before doing the search again.  I guess it works now
> >> that way because it was simpler to implement and nobody cared about
> >> handling this case specially.  But we could change the behavior of
> >> C-M-s in non-regexp mode to switch to regexp mode for consistency
> >> with C-M-%.
> >
> > But that's inconsistent with being able to use both C-s and M-C-s in
> > regexp searches.
> >
> > Don't you see that?
> 
> You can see the following comments for `isearch-mode-map' in isearch.el
> (underlining is mine):
> 
>     ;; Define M-C-s and M-C-r like C-s and C-r so that the same key
>     ;; combinations can be used to repeat regexp isearches that can
>                                           ================
>     ;; be used to start these searches.
> 
> So the meaning of C-M-s in a non-regexp search is still undefined,

Because of some internal comment?

> and the fact that C-M-s can repeat a non-regexp search is a side
> effect of the current implementation.

If you want to call explicitly coded "consistency" a side effect.

> And there is no symmetry between normal and regexp searches

Not?  Considering that both behave the same with regard to C-s and
C-M-s I would think there was.  And intentionally so.

-- 
David Kastrup, Kriemhildstr. 15, 44793 Bochum

  reply	other threads:[~2004-07-07 19:33 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-01 23:18 isearch-query-replace-regexp and stuff David Kastrup
2004-07-02  0:05 ` David Kastrup
2004-07-02 17:51   ` Richard Stallman
2004-07-02  6:55 ` Juri Linkov
2004-07-02  7:55   ` David Kastrup
2004-07-02 13:44     ` Stefan
2004-07-03  6:59     ` Juri Linkov
2004-07-03 18:20 ` Richard Stallman
2004-07-05 19:07   ` David Kastrup
2004-07-06  9:59     ` Juri Linkov
2004-07-06 11:20       ` David Kastrup
2004-07-06 16:36         ` Juri Linkov
2004-07-06 17:29           ` David Kastrup
2004-07-07  5:08             ` Juri Linkov
2004-07-07  9:29               ` David Kastrup
2004-07-07 18:29                 ` Juri Linkov
2004-07-07 19:33                   ` David Kastrup [this message]
2004-07-08 16:45                     ` Juri Linkov
2004-07-08 18:12                       ` David Kastrup
2004-07-09 20:54                         ` Juri Linkov
2004-07-08 23:17                 ` Richard Stallman
2004-07-06 22:00         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=x51xjnk3y0.fsf@lola.goethe.zz \
    --to=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).