Display problem with recent CVS

Display problem with recent CVS

[Piet van Oostrum]

I recompiled Carbon Emacs on MacOSX from the CVS version yesterday. I
noticed a strange display problem. It appears with creating emails with VM
with the vmpc extensions (which a.o. inserts a signature in a new message).
I don't know how to reproduce it in a virgin Emacs.

It starts with a buffer with the following contents:

,----
| To: 
| Subject: 
| X-Mailer: VM 7.19 under Emacs 21.3.50.13
| FCC: ~/Mail/OUTBOX
| ---------------------------------------------------------------------
| 
| -- 
| Piet van Oostrum <piet@cs.uu.nl>
| URL: http://www.cs.uu.nl/~piet [PGP]
| Private email: piet@vanoostrum.org
`----

When I start typing text in the body, followed by a RETURN, the signature
disappears. It is not removed from the buffer, just not displayed, because
it reappears with C-l. Is this a known problem?
-- 
Piet van Oostrum <piet@cs.uu.nl>
URL: http://www.cs.uu.nl/~piet [PGP]
Private email: P.van.Oostrum@hccnet.nl

Re: Display problem with recent CVS

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 03 Dec 2004 10:39:57 +0100, Piet van Oostrum <piet@cs.uu.nl> said:

> I recompiled Carbon Emacs on MacOSX from the CVS version
> yesterday. I noticed a strange display problem.
(snip)
> When I start typing text in the body, followed by a RETURN, the
> signature disappears. It is not removed from the buffer, just not
> displayed, because it reappears with C-l. Is this a known problem?

I encountered a similar phenomenon once, but I couldn't reproduce it.
The following patch partly undoes the 2004-11-30 change that is
related to scrolling.  Does this work for you?

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

Index: src/macterm.c
===================================================================
RCS file: /cvsroot/emacs/emacs/src/macterm.c,v
retrieving revision 1.83
diff -c -r1.83 macterm.c
*** src/macterm.c	30 Nov 2004 05:57:27 -0000	1.83
--- src/macterm.c	3 Dec 2004 10:51:28 -0000
***************
*** 912,924 ****
       int dest_x, dest_y;
  {
  #if TARGET_API_MAC_CARBON
!   Rect src_r;
!   RgnHandle dummy = NewRgn ();	/* For avoiding update events.  */
  
    SetRect (&src_r, src_x, src_y, src_x + width, src_y + height);
!   ScrollWindowRect (w, &src_r, dest_x - src_x, dest_y - src_y,
! 		    kScrollWindowNoOptions, dummy);
!   DisposeRgn (dummy);
  #else /* not TARGET_API_MAC_CARBON */
    Rect src_r, dest_r;
  
--- 912,935 ----
       int dest_x, dest_y;
  {
  #if TARGET_API_MAC_CARBON
!   Rect src_r, dest_r;
  
    SetRect (&src_r, src_x, src_y, src_x + width, src_y + height);
!   SetRect (&dest_r, dest_x, dest_y, dest_x + width, dest_y + height);
! 
!   SetPortWindowPort (w);
! 
!   ForeColor (blackColor);
!   BackColor (whiteColor);
! 
!   LockPortBits (GetWindowPort (w));
!   {
!     const BitMap *bitmap = GetPortBitMapForCopyBits (GetWindowPort (w));
!     CopyBits (bitmap, bitmap, &src_r, &dest_r, srcCopy, 0);
!   }
!   UnlockPortBits (GetWindowPort (w));
! 
!   mac_set_colors (gc);
  #else /* not TARGET_API_MAC_CARBON */
    Rect src_r, dest_r;

Re: Display problem with recent CVS

[Piet van Oostrum]

>>>>> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> (YM) wrote:

>>>>> On Fri, 03 Dec 2004 10:39:57 +0100, Piet van Oostrum <piet@cs.uu.nl> said:
>> I recompiled Carbon Emacs on MacOSX from the CVS version
>> yesterday. I noticed a strange display problem.
YM> (snip)
>> When I start typing text in the body, followed by a RETURN, the
>> signature disappears. It is not removed from the buffer, just not
>> displayed, because it reappears with C-l. Is this a known problem?

YM> I encountered a similar phenomenon once, but I couldn't reproduce it.
YM> The following patch partly undoes the 2004-11-30 change that is
YM> related to scrolling.  Does this work for you?

A first test indicates that this helps.
Thanks.
-- 
Piet van Oostrum <piet@cs.uu.nl>
URL: http://www.cs.uu.nl/~piet [PGP]
Private email: P.van.Oostrum@hccnet.nl