unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Ted Zlatanov <tzz@lifelogs.com>
To: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: questions about correct reveal-mode usage to hide passwords
Date: Fri, 12 Jun 2020 17:08:17 +0000	[thread overview]
Message-ID: <wo4c8b5q.fsf@lifelogs.com> (raw)
In-Reply-To: <1864384a-e0a4-8fa0-1185-4393bc104b17@gmail.com> ("Clément Pit-Claudel"'s message of "Fri, 12 Jun 2020 12:35:11 -0400")

On Fri, 12 Jun 2020 12:35:11 -0400 Clément Pit-Claudel <cpitclaudel@gmail.com> wrote: 

CP> On 12/06/2020 12.17, Ted Zlatanov wrote:
>> Let me know if you have strong objections or any suggestions, otherwise
>> in a day or two I'll document and push this patch.

CP> If you go this route, I would recommend extracting functionality shared between
CP> this and prettify-symbols-mode into a separate library; otherwise, won't you
CP> have conflicts between the password-hiding patterns and the prettification
CP> patterns? Additionally, I'd be surprised if turning of prettification also
CP> revealed passwords.

You're describing what I thought reveal-mode would do. It's a good
point, and factoring the functionality out to a library makes a lot of
sense.

Let's see if Stefan and others agree with the approach--remember, he
recommended using jit-lock. Once we have a solid foundation for this
functionality, I'm happy to start on the library.

Ted



  reply	other threads:[~2020-06-12 17:08 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-11 14:09 questions about correct reveal-mode usage to hide passwords Ted Zlatanov
2020-06-11 14:21 ` Clément Pit-Claudel
2020-06-11 17:33   ` Stefan Monnier
2020-06-11 17:43     ` Clément Pit-Claudel
2020-06-11 17:49       ` Stefan Monnier
2020-06-11 18:31         ` Ted Zlatanov
2020-06-11 19:51           ` Stefan Monnier
2020-06-12 16:17             ` Ted Zlatanov
2020-06-12 16:35               ` Clément Pit-Claudel
2020-06-12 17:08                 ` Ted Zlatanov [this message]
2020-06-16 18:09               ` Ted Zlatanov
2020-06-18 18:38                 ` Ted Zlatanov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wo4c8b5q.fsf@lifelogs.com \
    --to=tzz@lifelogs.com \
    --cc=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).