From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Filipe Cabecinhas <filcab@gmail.com>, emacs-devel@gnu.org
Subject: Re: visible-bell patch for Mac OS X
Date: Mon, 01 Feb 2010 09:41:13 +0900 [thread overview]
Message-ID: <wly6jdiy8m.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <87ljffx7zr.fsf@stupidchicken.com>
>>>>> On Sat, 30 Jan 2010 22:34:32 -0500, Chong Yidong <cyd@stupidchicken.com> said:
> Filipe Cabecinhas <filcab@gmail.com> writes:
>> I've made a patch to remove that ugly black rectangle
>> from ns_ring_bell, when visible-bell is 't. The patch makes Emacs
>> behave like the X version, inverting the colors of the top and
>> bottom lines, and bounces the Dock icon once if Emacs is not the
>> frontmost app (which can be extended to when visible-bell is 'nil,
>> if desired (just hoist it outside the if).
> Thanks. Looks good, I've checked it in.
2010-01-31 Filipe Cabecinhas <filcab@gmail.com> (tiny change)
* nsterm.m (ns_ring_bell): Handle visible bell like X.
The patch consists of ~80 lines. Is it considered a "tiny change"?
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2010-02-01 0:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-30 13:34 visible-bell patch for Mac OS X Filipe Cabecinhas
2010-01-31 3:34 ` Chong Yidong
2010-02-01 0:41 ` YAMAMOTO Mitsuharu [this message]
2010-02-01 15:56 ` Chong Yidong
2010-02-01 23:33 ` YAMAMOTO Mitsuharu
2010-02-02 1:40 ` YAMAMOTO Mitsuharu
2010-02-02 1:45 ` YAMAMOTO Mitsuharu
2010-02-02 8:47 ` Leo
2010-02-13 1:30 ` YAMAMOTO Mitsuharu
2010-02-13 1:51 ` David De La Harpe Golden
2010-02-13 3:54 ` Native scrollbars? [was: visible-bell patch for Mac OS X] Stephen J. Turnbull
2010-02-13 5:45 ` David De La Harpe Golden
2010-02-13 6:45 ` David De La Harpe Golden
2010-02-13 7:32 ` YAMAMOTO Mitsuharu
2010-02-13 13:32 ` Jan Djärv
2010-02-13 9:00 ` Native scrollbars? David Kastrup
2010-02-13 10:02 ` Eli Zaretskii
2010-02-13 12:23 ` Jan Djärv
2010-02-13 12:46 ` David Kastrup
2010-02-13 13:40 ` Jan Djärv
2010-02-13 14:26 ` David Kastrup
2010-02-13 13:50 ` Stephen J. Turnbull
2010-02-13 6:45 ` visible-bell patch for Mac OS X YAMAMOTO Mitsuharu
2010-02-13 7:01 ` David De La Harpe Golden
2010-02-13 7:54 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wly6jdiy8m.wl%mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=filcab@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).