From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Date: Mon, 04 Aug 2008 09:23:46 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1217809449 13177 80.91.229.12 (4 Aug 2008 00:24:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Aug 2008 00:24:09 +0000 (UTC) Cc: Dan Nicolaescu , Emanuele Giaquinta , Emacs Development To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 04 02:24:59 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KPnse-00039X-Jd for ged-emacs-devel@m.gmane.org; Mon, 04 Aug 2008 02:24:56 +0200 Original-Received: from localhost ([127.0.0.1]:45171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPnrj-000273-HY for ged-emacs-devel@m.gmane.org; Sun, 03 Aug 2008 20:23:59 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KPnre-00026q-PD for emacs-devel@gnu.org; Sun, 03 Aug 2008 20:23:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KPnrc-00026K-8b for emacs-devel@gnu.org; Sun, 03 Aug 2008 20:23:53 -0400 Original-Received: from [199.232.76.173] (port=43970 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KPnrc-00026D-5b for emacs-devel@gnu.org; Sun, 03 Aug 2008 20:23:52 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:50689 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KPnrb-0000Uc-Gr for emacs-devel@gnu.org; Sun, 03 Aug 2008 20:23:52 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 189262C46; Mon, 4 Aug 2008 09:23:46 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.2.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102015 Archived-At: >>>>> On Sun, 3 Aug 2008 12:41:22 -0400, Adrian Robert said: > This is not defined anywhere in emacs, but there was this section in > an earlier version of darwin.h: > #if 0 /* Don't define DARWIN on Mac OS X because CoreFoundation.h uses > it to distinguish Mac OS X from bare Darwin. */ > #ifndef DARWIN > #define DARWIN 1 > #endif > #endif > Does anyone know where this IS defined? Also, I've been unable to > find a version of CoreFoundation.h that makes the check referred to. It's used in CoreFoundation.h in Mac OS X 10.1 - 10.3. BTW, why the above comment was removed? The corresponding ChangeLog entry only says: 2008-07-10 Dan Nicolaescu * unexec.c: * s/vms.h: * s/usg5-4-2.h: * s/sol2-5.h: * s/freebsd.h: * s/darwin.h: Remove dead code. The comments like this should be left for future reference so people may not make the same mistake again. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp