unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Adrian Robert <adrian.b.robert@gmail.com>
Cc: Dan Nicolaescu <dann@ics.uci.edu>,
	Emanuele Giaquinta <emanuele.giaquinta@gmail.com>,
	Emacs Development <emacs-devel@gnu.org>
Subject: Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change)
Date: Mon, 04 Aug 2008 09:23:46 +0900	[thread overview]
Message-ID: <wlwsix1vcd.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <D6F7ABC9-C194-4964-9BCD-6FB94AD351A7@gmail.com>

>>>>> On Sun, 3 Aug 2008 12:41:22 -0400, Adrian Robert <adrian.b.robert@gmail.com> said:

> This is not defined anywhere in emacs, but there was this section in  
> an earlier version of darwin.h:

> #if 0 /* Don't define DARWIN on Mac OS X because CoreFoundation.h uses
>          it to distinguish Mac OS X from bare Darwin.  */
> #ifndef DARWIN
> #define DARWIN 1
> #endif
> #endif

> Does anyone know where this IS defined?  Also, I've been unable to  
> find a version of CoreFoundation.h that makes the check referred to.

It's used in CoreFoundation.h in Mac OS X 10.1 - 10.3.

BTW, why the above comment was removed?  The corresponding ChangeLog
entry only says:

  2008-07-10  Dan Nicolaescu  <dann@ics.uci.edu>

	  * unexec.c:
	  * s/vms.h:
	  * s/usg5-4-2.h:
	  * s/sol2-5.h:
	  * s/freebsd.h:
	  * s/darwin.h: Remove dead code.

The comments like this should be left for future reference so people
may not make the same mistake again.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp




  reply	other threads:[~2008-08-04  0:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu>
     [not found] ` <E465D318-490F-44DB-B8E2-04227EE9498A@gmail.com>
     [not found]   ` <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu>
     [not found]     ` <B6D54F89-C459-46DD-BEEA-DB723F7A725E@gmail.com>
     [not found]       ` <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu>
2008-08-03 16:41         ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Adrian Robert
2008-08-04  0:23           ` YAMAMOTO Mitsuharu [this message]
2008-08-04  1:20             ` fixing non-NS darwin Dan Nicolaescu
2008-08-04  2:03               ` YAMAMOTO Mitsuharu
2008-08-04  2:26                 ` Dan Nicolaescu
2008-08-04  3:49                   ` YAMAMOTO Mitsuharu
2008-08-04  4:02                     ` Dan Nicolaescu
2008-08-04  9:08                       ` Thien-Thi Nguyen
2008-08-04 11:53                         ` Dan Nicolaescu
2008-08-04  1:11           ` Dan Nicolaescu
2008-08-04 16:11           ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Adrian Robert
2008-08-04 17:31             ` fixing non-NS darwin Dan Nicolaescu
2008-08-05  9:21             ` fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) YAMAMOTO Mitsuharu
2008-08-04 13:59         ` Adrian Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wlwsix1vcd.wl%mituharu@math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=adrian.b.robert@gmail.com \
    --cc=dann@ics.uci.edu \
    --cc=emacs-devel@gnu.org \
    --cc=emanuele.giaquinta@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).