From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Pretest next week Date: Sat, 07 Mar 2009 09:48:09 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <815CC60C-5993-4A22-840A-C0E18A710068@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1236386907 6555 80.91.229.12 (7 Mar 2009 00:48:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 7 Mar 2009 00:48:27 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 07 01:49:43 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1LfkjV-0000dl-Jk for ged-emacs-devel@m.gmane.org; Sat, 07 Mar 2009 01:49:41 +0100 Original-Received: from localhost ([127.0.0.1]:49970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LfkiA-0000wR-B7 for ged-emacs-devel@m.gmane.org; Fri, 06 Mar 2009 19:48:18 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Lfki6-0000vy-5M for emacs-devel@gnu.org; Fri, 06 Mar 2009 19:48:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Lfki4-0000vc-JP for emacs-devel@gnu.org; Fri, 06 Mar 2009 19:48:13 -0500 Original-Received: from [199.232.76.173] (port=42994 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Lfki4-0000vI-DC for emacs-devel@gnu.org; Fri, 06 Mar 2009 19:48:12 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:63526) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Lfki2-0004JY-JP for emacs-devel@gnu.org; Fri, 06 Mar 2009 19:48:11 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 18AC52C4A for ; Sat, 7 Mar 2009 09:48:09 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:109499 Archived-At: >>>>> On Fri, 06 Mar 2009 10:01:38 +0900, YAMAMOTO Mitsuharu said: >> This causes a reentrant call to wait_reading_process_output, thence >> a reentrant call to ns_select. I've added a check in the latter to >> shortcircuit in the reentrant case. > I'm anxious whether the former reentrance (i.e., > wait_reading_process_output) is safe. Because wait_reading_process_output also calls timer_check, its reentrance would probably be OK. Still, I think Feval calls from read_socket_hook and (emulated) select are really bad. Most developers assume that these functions (and some higher-level ones such as detect_input_pending) don't call Feval, and they may add some code without noticing that NS breaks such assumptions. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp