From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Excessive redraw of overlapping/overlapped rows? Date: Mon, 26 Sep 2005 17:33:00 +0900 Organization: Faculty of Science, Chiba University Message-ID: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1127740777 29143 80.91.229.2 (26 Sep 2005 13:19:37 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 26 Sep 2005 13:19:37 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 26 15:19:33 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1EJsqm-0005Wk-Rl for ged-emacs-devel@m.gmane.org; Mon, 26 Sep 2005 15:16:57 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EJsqm-0004dF-0N for ged-emacs-devel@m.gmane.org; Mon, 26 Sep 2005 09:16:56 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EJpd7-0000ZC-Ar for emacs-devel@gnu.org; Mon, 26 Sep 2005 05:50:37 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EJpbP-0008C2-Ne for emacs-devel@gnu.org; Mon, 26 Sep 2005 05:48:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EJpW3-0005Li-LQ for emacs-devel@gnu.org; Mon, 26 Sep 2005 05:43:19 -0400 Original-Received: from [133.82.132.2] (helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EJoQ5-0001b0-Dv for emacs-devel@gnu.org; Mon, 26 Sep 2005 04:33:05 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 6EE8F2CB9 for ; Mon, 26 Sep 2005 17:33:00 +0900 (JST) Original-To: emacs-devel@gnu.org User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.6 (Marutamachi) APEL/10.6 Emacs/22.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:43247 Archived-At: In window_update (dispnew.c), overlapping/overlapped rows are redrawn if `changed_p' is non-zero. if (changed_p && rif->fix_overlapping_area) { redraw_overlapped_rows (w, yb); redraw_overlapping_rows (w, yb); } but this variable is set when either the mode line or the header line is updated. if (mode_line_row->mode_line_p && mode_line_row->enabled_p) { mode_line_row->y = yb; update_window_line (w, MATRIX_ROW_VPOS (mode_line_row, desired_matrix), &mouse_face_overwritten_p); changed_p = 1; } So when a user moves the cursor vertically and the line number displayed in the mode line is changed, the whole overlapping/overlapped rows get redrawn. It significantly degrades performance of cursor movement for such an environment that text drawing is not so fast. Is it OK to not set `changed_p' for the case of mode/header line updates? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp