From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: [sdl.web@gmail.com: Re: problem with transparent PNG image display] Date: Thu, 02 Aug 2007 09:36:46 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <46A527C9.7040401@gnu.org> <87vebze2nc.fsf@catnip.gol.com> <46B0ACF2.7020908@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1186015040 17527 80.91.229.12 (2 Aug 2007 00:37:20 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 2 Aug 2007 00:37:20 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, Miles Bader To: Jason Rumney Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Aug 02 02:37:13 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IGOgc-0005n6-75 for ged-emacs-devel@m.gmane.org; Thu, 02 Aug 2007 02:37:06 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IGOgb-0005iv-Oz for ged-emacs-devel@m.gmane.org; Wed, 01 Aug 2007 20:37:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IGOgX-0005i6-GD for emacs-devel@gnu.org; Wed, 01 Aug 2007 20:37:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IGOgV-0005gy-Mo for emacs-devel@gnu.org; Wed, 01 Aug 2007 20:37:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IGOgV-0005gm-IT for emacs-devel@gnu.org; Wed, 01 Aug 2007 20:36:59 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2] helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IGOgJ-0005mB-Sy; Wed, 01 Aug 2007 20:36:48 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 6CA302C40; Thu, 2 Aug 2007 09:36:46 +0900 (JST) In-Reply-To: <46B0ACF2.7020908@gnu.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.1.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-Detected-Kernel: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:75943 Archived-At: >>>>> On Wed, 01 Aug 2007 16:55:30 +0100, Jason Rumney said: > Miles Bader wrote: >> I thought it already did this (in image.c:search_image_cache): >> >> 2007-06-13 YAMAMOTO Mitsuharu >> >> * dispextern.h (struct image) [HAVE_WINDOW_SYSTEM]: New members >> frame_foreground and frame_background. >> >> * image.c (lookup_image): Save frame foreground and background colors. >> (search_image_cache): Check if saved and current frame colors match. >> > I think its the background on which the image is rendered that is > important, not the frame background. The toolbar has its own background > color, independent of the frame's. And that only covers caching, images > still need to be drawn with the appropriate background from the face > rather than the background color saved in the image file itself. FWIW, that change was just for fixing excessive image cache miss (and performance degradation caused by needless image regeneration) in the trunk, without affecting its original intention. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp