unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Yuan MEI <yuan.mei.list@gmail.com>
Cc: martin rudalics <rudalics@gmx.at>, Eli Zaretskii <eliz@gnu.org>,
	emacs-devel <emacs-devel@gnu.org>
Subject: Re: Redisplay issue
Date: Mon, 07 Dec 2015 12:33:22 +0900	[thread overview]
Message-ID: <wlr3izorul.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <CANGGyWayd-4OfTiNC3z=mtAcogC2_EFs9wN5VvX8M=ya4-mw8Q@mail.gmail.com>

>>>>> On Sat, 5 Dec 2015 16:49:29 -0800, Yuan MEI <yuan.mei.list@gmail.com> said:

>>> Maybe one font backend rounds the fractional metrics values but
>>> the other truncates them?
>> 
>> Could be.  Yuan, could you try these changes, and see if the
>> dimensions of the Cairo frame become identical to that of the
>> non-Cairo build?

> I tried the patch.  However Cairo frame and non-Cairo frame still
> differ by the same amount as reported before.

So, rounding has nothing to do with the difference you observe.

It seems that freetype has two types of structures containing metrics
values (ascender, descender, height): FT_FaceRec and FT_Size_Metrics.
ftfont.c uses the former for scalable fonts and the latter for the
other cases.

ftfont.c in Emacs:

  if (scalable)
    {
      font->ascent = ft_face->ascender * size / upEM + 0.5;
      font->descent = - ft_face->descender * size / upEM + 0.5;
      font->height = ft_face->height * size / upEM + 0.5;
    }
  else
    {
      font->ascent = ft_face->size->metrics.ascender >> 6;
      font->descent = - ft_face->size->metrics.descender >> 6;
      font->height = ft_face->size->metrics.height >> 6;
    }

libXft internally uses the latter only.

xftfreetype.c in libXft:

    if (fi->transform)
    {
/* snip */
    }
    else
    {
	descent = -(face->size->metrics.descender >> 6);
	ascent = face->size->metrics.ascender >> 6;
	if (fi->minspace)
	    height = ascent + descent;
	else
	    height = face->size->metrics.height >> 6;
    }
    font->public.ascent = ascent;
    font->public.descent = descent;
    font->public.height = height;

I don't know which is correct/appropriate.  At least, there is a case
that these two kinds of values are different.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp



  reply	other threads:[~2015-12-07  3:33 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-27 22:31 Redisplay issue Yuan MEI
2015-11-28  8:06 ` Eli Zaretskii
2015-11-28  8:27   ` Yuan MEI
2015-11-28  9:44     ` Eli Zaretskii
2015-11-28 20:19       ` Yuan MEI
2015-11-28 20:49         ` Eli Zaretskii
2015-11-29  2:54           ` Yuan MEI
2015-11-29 15:42             ` Eli Zaretskii
2015-11-29 23:35               ` Yuan MEI
2015-11-30 16:16                 ` Eli Zaretskii
2015-12-01  4:51                   ` Yuan MEI
2015-12-01 16:01                     ` Eli Zaretskii
2015-12-02  4:35                       ` Yuan MEI
2015-12-02 13:57                         ` Eli Zaretskii
2015-12-03  4:55                           ` Yuan MEI
2015-12-03  7:47                             ` Eli Zaretskii
2015-12-03  8:09                               ` Yuan MEI
2015-12-03 10:23                                 ` Eli Zaretskii
2015-12-03 18:16                                 ` martin rudalics
2015-12-03 21:23                                   ` Yuan MEI
2015-12-04  8:08                                     ` martin rudalics
2015-12-04  8:30                                       ` Yuan MEI
2015-12-04  8:48                                         ` martin rudalics
2015-12-04  8:54                                           ` Yuan MEI
2015-12-04  8:56                                           ` martin rudalics
2015-12-04  9:00                                             ` Yuan MEI
2015-12-04  9:05                                               ` martin rudalics
2015-12-04  9:47                                                 ` Eli Zaretskii
2015-12-04 10:21                                                   ` martin rudalics
2015-12-04 11:01                                                     ` Eli Zaretskii
2015-12-04 11:12                                                       ` Eli Zaretskii
2015-12-05  0:25                                                   ` YAMAMOTO Mitsuharu
2015-12-05  9:17                                                     ` Eli Zaretskii
2015-12-06  0:49                                                       ` Yuan MEI
2015-12-07  3:33                                                         ` YAMAMOTO Mitsuharu [this message]
2015-12-07 17:19                                                           ` Eli Zaretskii
2015-12-08  4:03                                                             ` YAMAMOTO Mitsuharu
2015-12-11  8:48                                                               ` Eli Zaretskii
2015-11-28 21:44   ` joakim
2015-11-29  0:14     ` Yuan MEI

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wlr3izorul.wl%mituharu@math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=rudalics@gmx.at \
    --cc=yuan.mei.list@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).