unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: emacs-devel@gnu.org
Subject: Re: EVENT_INIT and obs. kbd_buffer_gcpro: 'arg' init still needed?
Date: Thu, 01 Jun 2006 18:56:47 +0900	[thread overview]
Message-ID: <wlpshtdwrk.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <158D3CCD-6D78-4861-AEE8-C1F032DBBB15@cogsci.ucsd.edu>

>>>>> On Wed, 31 May 2006 09:50:35 -0400, Adrian Robert <arobert@cogsci.ucsd.edu> said:

> One use of the termhooks.h EVENT_INIT() macro in macterm.c also takes  
> care to init the event's 'arg' to "Qnil", explaining with this comment:

>        /* It is necessary to set this (additional) argument slot of an
> 	 event to nil because keyboard.c protects incompletely
> 	 processed event from being garbage collected by placing them
> 	 in the kbd_buffer_gcpro vector.  */

> However, according to the ChangeLog this vector was removed on
> 2004-01-21 in response to changes on 2003-06-15, including the very
> introduction of the EVENT_INIT() macro.

I removed this comment that is referring to a nonexistent variable
from macterm.c.

> My question is, is the additional call to set 'arg' to "Qnil", found
> in w32, mac, and x terms, still needed?  I notice that macterm does
> not have it for other calls to EVENT_INIT.  Other terms only use
> EVENT_INIT once.

Although bzero'ed Lisp_Object corresponds to integer 0 and thus it
does not leads to a real problem, I think we should not rely on this.
So I added some code to set `arg' to Qnil in macterm.c.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

  reply	other threads:[~2006-06-01  9:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31 13:50 EVENT_INIT and obs. kbd_buffer_gcpro: 'arg' init still needed? Adrian Robert
2006-06-01  9:56 ` YAMAMOTO Mitsuharu [this message]
2006-06-01 13:16   ` Adrian Robert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wlpshtdwrk.wl%mituharu@math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).