unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: alarm_signal_handler is called too frequently
Date: Fri, 29 Oct 2004 17:24:02 +0900	[thread overview]
Message-ID: <wloeimylst.wl@church.math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <4181EA7E.2020309@swipnet.se>

>>>>> On Fri, 29 Oct 2004 09:00:14 +0200, "Jan D." <jan.h.d@swipnet.se> said:

>> That's the reason why I did the following question:
>> 
>>   I think we don't have to call set_alarm when pending_atimers is
>>   non-zero because do_pending_atimers is supposed to be called
>>   eventually in such a case.  Is that correct?

> You mean like this?

> +   if (! (pending_atimers && interrupt_input_blocked))
>        set_alarm ();

> That works and should save a couple of CPU cycles.

I've been using the similar patch in

  http://lists.gnu.org/archive/html/emacs-devel/2004-10/msg00553.html

for two weeks on Solaris/X11 and Mac OS X/Carbon, and it seems to work
fine for me.

Reduction of CPU cycles is prominent in Mac OS X/Carbon where
BLOCK_INPUT is enabled for a long time while waiting for some user
input in sys_select (mac.c).  We need BLOCK_INPUT (or something like
this) here because the only way to know whether input is available or
not is to call ReceiveNextEvent, and this function is not reentrant.
I think we don't have to poll input with signal while waiting for
input.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

  reply	other threads:[~2004-10-29  8:24 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-10-13  1:15 alarm_signal_handler is called too frequently YAMAMOTO Mitsuharu
2004-10-13 14:43 ` Richard Stallman
2004-10-14  5:16   ` YAMAMOTO Mitsuharu
2004-10-17  9:36     ` YAMAMOTO Mitsuharu
2004-10-25 13:13       ` Richard Stallman
2004-10-25 14:38         ` Jan D.
2004-10-27 10:47           ` Richard Stallman
2004-10-28 18:02             ` Jan D.
2004-10-29  1:37               ` YAMAMOTO Mitsuharu
2004-10-29  7:00                 ` Jan D.
2004-10-29  8:24                   ` YAMAMOTO Mitsuharu [this message]
2004-11-01  7:24                   ` Richard Stallman
2004-11-01  9:06                     ` Jan D.
2004-11-01 12:21                       ` Jan D.
2004-11-02 14:08                       ` Richard Stallman
2004-11-02 21:56                         ` Jan D.
2004-11-03 17:04                           ` Richard Stallman
2004-11-03 17:26                             ` Jan D.
2004-11-04 20:42                               ` Richard Stallman
2004-11-04 22:41                             ` Jan D.
2004-11-05 12:36                               ` Kim F. Storm
2004-11-06  5:22                                 ` Richard Stallman
2004-11-04 13:02                         ` Jan D.
2004-10-31  9:42               ` Richard Stallman
2004-10-31 15:11                 ` Jan D.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wloeimylst.wl@church.math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).