From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel,gmane.emacs.pretest.bugs Subject: Re: Carbon / USE_MAC_TOOLBAR: click in tool bar doesn't raise frame Date: Thu, 17 Apr 2008 09:44:24 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <20ecf6c70804160707t7e7881c4wdf0fbdc28b2f9bb7@mail.gmail.com> <83110B73-CA3A-42CA-B4D5-E25F66D805E1@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1208393866 19712 80.91.229.12 (17 Apr 2008 00:57:46 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Apr 2008 00:57:46 +0000 (UTC) Cc: emacs-pretest-bug@gnu.org, Nathaniel Cunningham To: David Reitter Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 02:58:14 2008 connect(): Connection refused Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JmIS4-0005r5-Kc for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2008 02:58:12 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmIRP-00015X-TP for ged-emacs-devel@m.gmane.org; Wed, 16 Apr 2008 20:57:31 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JmIRK-00013E-GZ for emacs-devel@gnu.org; Wed, 16 Apr 2008 20:57:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JmIRI-00011x-Td for emacs-devel@gnu.org; Wed, 16 Apr 2008 20:57:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JmIRI-00011p-Fu for emacs-devel@gnu.org; Wed, 16 Apr 2008 20:57:24 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmIRI-0001Sh-56 for emacs-devel@gnu.org; Wed, 16 Apr 2008 20:57:24 -0400 Original-Received: from mx10.gnu.org ([199.232.76.166]) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1JmIRH-0006Mf-Rh for emacs-pretest-bug@gnu.org; Wed, 16 Apr 2008 20:57:23 -0400 Original-Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1JmIEn-00079R-DI for emacs-pretest-bug@gnu.org; Wed, 16 Apr 2008 20:44:32 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2] helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JmIEm-00078T-Ol for emacs-pretest-bug@gnu.org; Wed, 16 Apr 2008 20:44:29 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 445C82C40; Thu, 17 Apr 2008 09:44:24 +0900 (JST) In-Reply-To: <83110B73-CA3A-42CA-B4D5-E25F66D805E1@gmail.com> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:95379 gmane.emacs.pretest.bugs:22053 Archived-At: >>>>> On Wed, 16 Apr 2008 18:28:44 +0100, David Reitter said: > This affects the 22 branch Carbon build. Begin forwarded message: >> From: "Nathaniel Cunningham" Date: >> 16 April 2008 15:07:15 BST >> >> With the new tool bar in nightly builds, I find that clicking in >> the tool bar doesn't raise the frame, whether clicking on an active >> icon, a disabled icon, or blank bar in between. This is counter- >> intuitive and should be fixed if possible. > Clicking on a disabled icon should raise the frame, while clicks on > non-disabled icons should work as they do (standard click-through > behavior). This doesn't currently work. Thanks for the report. Could you try this? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp Index: src/mactoolbox.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/Attic/mactoolbox.c,v retrieving revision 1.1.2.2 diff -c -p -r1.1.2.2 mactoolbox.c *** src/mactoolbox.c 7 Apr 2008 07:13:07 -0000 1.1.2.2 --- src/mactoolbox.c 17 Apr 2008 00:43:13 -0000 *************** XTread_socket (sd, expected, hold_quit) *** 3560,3565 **** --- 3558,3566 ---- OSStatus err; HIViewRef ch; + if (FrontNonFloatingWindow () != window_ptr) + SelectWindow (window_ptr); + err = HIViewGetViewForMouseEvent (HIViewGetRoot (window_ptr), eventRef, &ch); /* This doesn't work on Mac OS X 10.2. */