From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: fixing non-NS darwin (was: Re: your emacs/src/keyboard.h change) Date: Tue, 05 Aug 2008 18:21:43 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <200808011544.m71Fi4UD026726@sallyv1.ics.uci.edu> <200808011605.m71G5Wmb010785@sallyv1.ics.uci.edu> <200808031559.m73Fx8wt013987@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1217928141 30118 80.91.229.12 (5 Aug 2008 09:22:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 5 Aug 2008 09:22:21 +0000 (UTC) Cc: Emacs Development To: Adrian Robert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 05 11:23:12 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1KQIl5-0007nK-Pf for ged-emacs-devel@m.gmane.org; Tue, 05 Aug 2008 11:23:12 +0200 Original-Received: from localhost ([127.0.0.1]:43105 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQIkA-0002oM-Ep for ged-emacs-devel@m.gmane.org; Tue, 05 Aug 2008 05:22:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQIjk-0002Ua-2Y for emacs-devel@gnu.org; Tue, 05 Aug 2008 05:21:48 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQIji-0002T0-Rd for emacs-devel@gnu.org; Tue, 05 Aug 2008 05:21:46 -0400 Original-Received: from [199.232.76.173] (port=50789 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQIji-0002Sl-3D for emacs-devel@gnu.org; Tue, 05 Aug 2008 05:21:46 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:65038 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQIjh-0003h2-GB for emacs-devel@gnu.org; Tue, 05 Aug 2008 05:21:46 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 44A8B2C40; Tue, 5 Aug 2008 18:21:43 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.2.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:102080 Archived-At: >>>>> On Mon, 4 Aug 2008 12:11:31 -0400, Adrian Robert said: > I've also gone through the removal diff and wanted to ask about the > bit below since it may be something that all terms should do: Well, careful (as opposed to casual) readers would pay attention to such a comment (not written by me, IIRC). A related discussion is found at: http://lists.gnu.org/archive/html/emacs-pretest-bug/2004-04/msg00141.html Still I can't clearly explain why it is ok to do a longjmp and not execute the call to set_alarm from alarm_signal_handler. But this change does fix a particular problem and at least does not make things worse, and it has been working well with Carbon Emacs 22 for a long time. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp > Index: atimer.c > =================================================================== > RCS file: /sources/emacs/emacs/src/atimer.c,v > retrieving revision 1.28 > retrieving revision 1.27 > diff -u -r1.28 -r1.27 > --- atimer.c 27 Jul 2008 18:24:40 -0000 1.28 > +++ atimer.c 14 May 2008 07:49:08 -0000 1.27 > @@ -368,7 +368,9 @@ > > t = atimers; > atimers = atimers->next; > +#ifndef MAC_OSX > t-> fn (t); > +#endif > > if (t->type == ATIMER_CONTINUOUS) > { > @@ -380,6 +382,10 @@ > t->next = free_atimers; > free_atimers = t; > } > +#ifdef MAC_OSX > + /* Fix for Ctrl-G. Perhaps this should apply to all platforms. > */ > + t->fn (t); > +#endif > > EMACS_GET_TIME (now); > }