From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: Po Lu <luangruo@yahoo.com>
Cc: emacs-devel@gnu.org
Subject: Re: master cd88f6de4b: Adjust zero-width grapheme clusters so they are displayed (Bug#50951)
Date: Tue, 27 Sep 2022 12:26:54 +0900 [thread overview]
Message-ID: <wlo7v1fqf5.wl-mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <871qrxa5z6.fsf@yahoo.com>
On Tue, 27 Sep 2022 11:47:25 +0900,
Po Lu wrote:
>
> YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp> writes:
>
> > branch: master
> > commit cd88f6de4be1f8eba1db038b371d769f584be53b
> > Author: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> > Commit: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
> >
> > Adjust zero-width grapheme clusters so they are displayed (Bug#50951)
> >
> > * src/composite.c (composition_gstring_adjust_zero_width): New function.
> > * src/composite.h: Declare it.
> > * src/font.c (Ffont_shape_gstring): Use it before putting gstring to cache.
>
> This gives:
>
> In file included from composite.c:29:
> In function ‘AREF’,
> inlined from ‘composition_gstring_adjust_zero_width’ at composite.c:839:11:
> lisp.h:1941:35: warning: ‘glyph’ may be used uninitialized [-Wmaybe-uninitialized]
> 1941 | return XVECTOR (array)->contents[idx];
> | ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~
> composite.c: In function ‘composition_gstring_adjust_zero_width’:
> composite.c:816:19: note: ‘glyph’ was declared here
> 816 | Lisp_Object glyph;
> | ^~~~~
>
This is a false alarm. The variable `glyph' is left uninitialized
only when i == LGSTRING_GLYPH_LEN (gstring), and all the uses are
guarded by this condition. So the usual practice is to add UNINIT in
this case?
YAMAMOTO Mitsuharu
mituharu@math.s.chiba-u.ac.jp
next prev parent reply other threads:[~2022-09-27 3:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <166423829576.7468.2672204708444997712@vcs2.savannah.gnu.org>
[not found] ` <20220927002456.D4AC2C11D7D@vcs2.savannah.gnu.org>
2022-09-27 2:47 ` master cd88f6de4b: Adjust zero-width grapheme clusters so they are displayed (Bug#50951) Po Lu
2022-09-27 3:26 ` YAMAMOTO Mitsuharu [this message]
2022-09-27 3:33 ` Po Lu
2022-09-27 3:46 ` YAMAMOTO Mitsuharu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=wlo7v1fqf5.wl-mituharu@math.s.chiba-u.ac.jp \
--to=mituharu@math.s.chiba-u.ac.jp \
--cc=emacs-devel@gnu.org \
--cc=luangruo@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).