From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Toolbars on MacOSX Date: Tue, 11 May 2004 18:49:17 +0900 Organization: Faculty of Science, Chiba University Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1084269086 7101 80.91.224.253 (11 May 2004 09:51:26 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 11 May 2004 09:51:26 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue May 11 11:51:11 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNTup-0007HL-00 for ; Tue, 11 May 2004 11:51:11 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BNTup-0000AK-00 for ; Tue, 11 May 2004 11:51:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNTtz-0006yc-3T for emacs-devel@quimby.gnus.org; Tue, 11 May 2004 05:50:19 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.34) id 1BNTtZ-0006rx-KR for emacs-devel@gnu.org; Tue, 11 May 2004 05:49:53 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.34) id 1BNTt3-0006ji-D2 for emacs-devel@gnu.org; Tue, 11 May 2004 05:49:52 -0400 Original-Received: from [133.82.132.2] (helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BNTt2-0006jM-G2 for emacs-devel@gnu.org; Tue, 11 May 2004 05:49:21 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 9039E1A63AD; Tue, 11 May 2004 18:49:17 +0900 (JST) Original-To: Piet van Oostrum In-Reply-To: User-Agent: Wanderlust/2.10.1 (Watching The Wheels) SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:23126 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:23126 >>>>> On 04 May 2004 23:16:20 +0200, Piet van Oostrum said: > Now there's image support in CVS emacs for MacOSX, I would think > toolbars should work. However, I can't get it working (I tried for > VM). Is there anything that prevents toolbars on MacOSX or is there > some incantation that I missed? Currently, toolbars are not enabled by default. Try M-x tool-bar-mode RET. There is a bug that a toolbar button is not highlighted just after being clicked. The following patch will solve the problem. I would suggest enabling toolbars by default together with the XPM support code that I posted the other day. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp Index: src/macterm.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/macterm.c,v retrieving revision 1.67 diff -c -r1.67 macterm.c *** src/macterm.c 7 May 2004 17:46:50 -0000 1.67 --- src/macterm.c 10 May 2004 13:04:26 -0000 *************** *** 1210,1216 **** FOR_EACH_FRAME (rest, frame) x_flush (XFRAME (frame)); } ! else if (FRAME_X_P (f)) XFlush (FRAME_MAC_DISPLAY (f)); UNBLOCK_INPUT; #endif /* TARGET_API_MAC_CARBON */ --- 1210,1216 ---- FOR_EACH_FRAME (rest, frame) x_flush (XFRAME (frame)); } ! else if (FRAME_MAC_P (f)) XFlush (FRAME_MAC_DISPLAY (f)); UNBLOCK_INPUT; #endif /* TARGET_API_MAC_CARBON */ *************** *** 1410,1416 **** XTframe_up_to_date (f) struct frame *f; { ! if (FRAME_X_P (f)) { struct mac_display_info *dpyinfo = FRAME_MAC_DISPLAY_INFO (f); --- 1410,1416 ---- XTframe_up_to_date (f) struct frame *f; { ! if (FRAME_MAC_P (f)) { struct mac_display_info *dpyinfo = FRAME_MAC_DISPLAY_INFO (f);