unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
To: merlyn@stonehenge.com (Randal L. Schwartz)
Cc: emacs-devel@gnu.org
Subject: Re: OSX "new frame" mangles default face
Date: Thu, 09 Aug 2007 16:52:13 +0900	[thread overview]
Message-ID: <wllkcluouq.wl%mituharu@math.s.chiba-u.ac.jp> (raw)
In-Reply-To: <86abt1p4f0.fsf@blue.stonehenge.com>

>>>>> On Thu, 09 Aug 2007 00:12:35 -0700, merlyn@stonehenge.com (Randal L. Schwartz) said:

> As a data point, I just checked out EMACS_22_1 and recompiled, and
> the problem is *not* in there.  I get the original behavior that
> I've come to expect... new frame keeps same default face.

> So it's something introduced between 22.1 and CVS HEAD.  Hope that
> helps.

I could get the 22.1 behavior by undoing the following change:

2007-08-03  Daiki Ueno  <ueno@unixuser.org>

	* faces.el (face-normalize-spec): New function.
	(frame-set-background-mode): Normalize face-spec before calling
	face-spec-match-p.

http://lists.gnu.org/archive/html/emacs-devel/2007-07/msg01682.html

Actually, the following usage of `face-normalize-spec' in
`frame-set-background-mode' looks strange.

	(dolist (face (face-list))
	  (when (not (face-spec-match-p face
					(face-normalize-spec
					 (face-user-default-spec face))
					(selected-frame)))
	    (push face locally-modified-faces)))

For example,

  % emacs -Q -D

  (face-default-spec 'italic)
  => ((((supports :slant italic)) :slant italic) (((supports :underline t)) :underline t) (t :slant italic))

  (face-normalize-spec (face-default-spec 'italic))
  => nil

while

  (face-normalize-spec (face-spec-choose (face-default-spec 'italic)))
  => (:slant italic)

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

  reply	other threads:[~2007-08-09  7:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-09  6:46 OSX "new frame" mangles default face Randal L. Schwartz
2007-08-09  7:12 ` Randal L. Schwartz
2007-08-09  7:52   ` YAMAMOTO Mitsuharu [this message]
2007-08-09  9:48     ` Daiki Ueno
2007-08-15 23:15       ` Randal L. Schwartz
2007-08-24 15:13       ` Randal L. Schwartz
2007-10-09  2:10       ` YAMAMOTO Mitsuharu
2007-11-02  8:45         ` YAMAMOTO Mitsuharu
2007-08-09 23:11 ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=wllkcluouq.wl%mituharu@math.s.chiba-u.ac.jp \
    --to=mituharu@math.s.chiba-u.ac.jp \
    --cc=emacs-devel@gnu.org \
    --cc=merlyn@stonehenge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).