From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Display performance degradation Date: Sat, 19 Dec 2009 11:56:47 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <4B2A5F92.9090008@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1261191468 23218 80.91.229.12 (19 Dec 2009 02:57:48 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 19 Dec 2009 02:57:48 +0000 (UTC) Cc: emacs-devel@gnu.org To: Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Dec 19 03:57:40 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1NLpVi-0005gL-Tk for ged-emacs-devel@m.gmane.org; Sat, 19 Dec 2009 03:57:39 +0100 Original-Received: from localhost ([127.0.0.1]:35829 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLpVi-0005QR-Lz for ged-emacs-devel@m.gmane.org; Fri, 18 Dec 2009 21:57:38 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NLpV2-0005IC-5P for emacs-devel@gnu.org; Fri, 18 Dec 2009 21:56:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NLpUw-0005EW-UZ for emacs-devel@gnu.org; Fri, 18 Dec 2009 21:56:54 -0500 Original-Received: from [199.232.76.173] (port=49098 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NLpUw-0005ED-F3 for emacs-devel@gnu.org; Fri, 18 Dec 2009 21:56:50 -0500 Original-Received: from mathmail.math.s.chiba-u.ac.jp ([133.82.132.2]:63971) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NLpUv-0007SV-Ug for emacs-devel@gnu.org; Fri, 18 Dec 2009 21:56:50 -0500 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id A89BEC0560; Sat, 19 Dec 2009 11:56:47 +0900 (JST) In-Reply-To: User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:118737 Archived-At: While I was looking at font caching code, I found a part that seems to be wrong, though it is not directly related to the original performance issue. Fclear_font_cache (in src/font.c): 4484 val = XCDR (cache); 4485 while (! NILP (val) 4486 && ! EQ (XCAR (XCAR (val)), driver_list->driver->type)) 4487 val = XCDR (val); 4488 font_assert (! NILP (val)); 4489 val = XCDR (XCAR (val)); 4490 if (XINT (XCAR (val)) == 0) 4491 { 4492 font_clear_cache (f, XCAR (val), driver_list->driver); 4493 XSETCDR (cache, XCDR (val)); 4494 } 4495 } At line 4490, XCAR (val) is expected to be of type Lisp integer. But it is also passed to font_clear_cache at line 4492, which seems to expect the value of `val' as of line 4488 rather than the one assigned at line 4489. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp