From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: [Stephen.Berman@gmx.net: Re: redisplay] Date: Fri, 27 Apr 2007 17:57:57 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87mz0z5dux.fsf@stupidchicken.com> <462D059B.7020001@swipnet.se> <87d51u211n.fsf@escher.local.home> <20070424.075017.71197070.mituharu@math.s.chiba-u.ac.jp> <87lkgergy1.fsf@escher.local.home> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1177664293 15558 80.91.229.12 (27 Apr 2007 08:58:13 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 27 Apr 2007 08:58:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 27 10:58:12 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HhMHL-00071T-Lm for ged-emacs-devel@m.gmane.org; Fri, 27 Apr 2007 10:58:11 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HhMNA-0008NL-MG for ged-emacs-devel@m.gmane.org; Fri, 27 Apr 2007 05:04:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HhMN5-0008LX-IJ for emacs-devel@gnu.org; Fri, 27 Apr 2007 05:04:07 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HhMN3-0008KK-HF for emacs-devel@gnu.org; Fri, 27 Apr 2007 05:04:06 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HhMN3-0008KH-AF for emacs-devel@gnu.org; Fri, 27 Apr 2007 05:04:05 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2] helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HhMHD-0004YP-1U for emacs-devel@gnu.org; Fri, 27 Apr 2007 04:58:03 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id AD58D2C40 for ; Fri, 27 Apr 2007 17:57:57 +0900 (JST) In-Reply-To: <87lkgergy1.fsf@escher.local.home> <20070424.075017.71197070.mituharu@math.s.chiba-u.ac.jp> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.0.99 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:70231 Archived-At: >>>>> On Thu, 26 Apr 2007 22:58:30 +0200, Stephen Berman said: >> Stephen, could try the following patch? I don't think this is a >> right fix, but at least we can check if we are sharing the same >> issue. > I applied your patch and rebuilt Emacs, and I still see the blank > frame, though, as I mentioned in my previous followup, I don't see > the effect as consistently as I had thought and reported in my > original followup. Thanks for testing. >>>>> On Tue, 24 Apr 2007 07:50:17 +0900 (JST), YAMAMOTO Mitsuharu said: > To make things work, expose_frame must correctly draw the contents > most of the time. But with the experiment of compositing windows, I > observe that is not always the case even if !FRAME_GARBARGED_P(f) && > updated_window != NULL. It seems to fail to do so after the current > matrix is updated with try_window_reusing_current_matrix under a > certain condition, but I haven't figured it out yet. Though my issue above has turned out to be unrelated to the dialog one, I think I figured out the problematic case for my issue. In try_window_reusing_current_matrix (the scroll-down case), `it.vpos' rows in the current matrix are disabled. But the scroll-down height in rows is stored in `nrows_scrolled' and they differ by 1 when the header line is present. As a result, the first row of the reused part is erroneously disabled and the rows below it don't get redrawn by Expose events. The following patch seems to work for me. Could someone check it and comment on whether it should be installed before the release or not? YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp Index: src/xdisp.c =================================================================== RCS file: /cvsroot/emacs/emacs/src/xdisp.c,v retrieving revision 1.1149 diff -c -p -r1.1149 xdisp.c *** src/xdisp.c 24 Apr 2007 01:32:41 -0000 1.1149 --- src/xdisp.c 27 Apr 2007 08:37:31 -0000 *************** try_window_reusing_current_matrix (w) *** 13811,13817 **** nrows_scrolled); /* Disable lines that must be updated. */ ! for (i = 0; i < it.vpos; ++i) (start_row + i)->enabled_p = 0; /* Re-compute Y positions. */ --- 13811,13817 ---- nrows_scrolled); /* Disable lines that must be updated. */ ! for (i = 0; i < nrows_scrolled; ++i) (start_row + i)->enabled_p = 0; /* Re-compute Y positions. */