From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: mouse-face highlighting broken? Date: Thu, 07 May 2009 15:29:06 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87iqke6xx3.fsf@cyd.mit.edu> <357AADAB-5EEF-456A-9C7B-D851376EB118@gmail.com> <006401c9ce73$57448900$c2b22382@us.oracle.com> <874ovxwmei.fsf@cyd.mit.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1241677780 30283 80.91.229.12 (7 May 2009 06:29:40 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 May 2009 06:29:40 +0000 (UTC) Cc: David Reitter , Adrian Robert , Drew Adams , Emacs-Devel devel To: Chong Yidong Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 07 08:29:29 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1M1x6n-00021w-Iy for ged-emacs-devel@m.gmane.org; Thu, 07 May 2009 08:29:29 +0200 Original-Received: from localhost ([127.0.0.1]:58770 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1x6m-0007Tp-NY for ged-emacs-devel@m.gmane.org; Thu, 07 May 2009 02:29:28 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1M1x6d-0007Rn-N3 for emacs-devel@gnu.org; Thu, 07 May 2009 02:29:19 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1M1x6Y-0007Pp-OG for emacs-devel@gnu.org; Thu, 07 May 2009 02:29:18 -0400 Original-Received: from [199.232.76.173] (port=58827 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1M1x6Y-0007Pi-GQ for emacs-devel@gnu.org; Thu, 07 May 2009 02:29:14 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:61726 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1M1x6X-0001hV-Mp for emacs-devel@gnu.org; Thu, 07 May 2009 02:29:14 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 7EFC12C43; Thu, 7 May 2009 15:29:07 +0900 (JST) In-Reply-To: <874ovxwmei.fsf@cyd.mit.edu> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/22.3 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-operating-system: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:110745 Archived-At: >>>>> On Thu, 07 May 2009 00:46:13 -0400, Chong Yidong said: >> With that, I took a look at the relevant code in the NS port, and >> it turns out that ns_dumpglyphs_stretch() and ns_dumpglyphs_image() >> fail to use the mouse face instead of the first glyph face. The >> patch below addresses that. > This patch looks reasonable to me. It might be OK to apply such a change for now, but I'd rather think if the NS port had a similar code structure to the other terms, an oversight like this case would hardly happen in the first place. The other terms consolidate the mouse face handling into one function x_set_mouse_face_gc rather than scattering it into 3 (the proposed change makes it 5) places. Also, this uniformity among different terms makes it easier for other terms to catch up with xterm.c changes. YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp