From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: YAMAMOTO Mitsuharu Newsgroups: gmane.emacs.devel Subject: Re: Carbon port and multi-tty Date: Thu, 08 May 2008 09:21:31 +0900 Organization: Faculty of Science, Chiba University Message-ID: References: <87r6cf1if3.fsf@stupidchicken.com> <200805070428.m474SbH6002408@sallyv1.ics.uci.edu> <200805070555.m475tCRi004681@sallyv1.ics.uci.edu> <200805070715.m477FqOT010542@sallyv1.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Trace: ger.gmane.org 1210206124 1085 80.91.229.12 (8 May 2008 00:22:04 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 8 May 2008 00:22:04 +0000 (UTC) Cc: Chong Yidong , Stefan Monnier , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 08 02:22:37 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Jtttv-0007MT-Tj for ged-emacs-devel@m.gmane.org; Thu, 08 May 2008 02:22:24 +0200 Original-Received: from localhost ([127.0.0.1]:46171 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JtttD-0006IY-Od for ged-emacs-devel@m.gmane.org; Wed, 07 May 2008 20:21:39 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JtttA-0006HA-GE for emacs-devel@gnu.org; Wed, 07 May 2008 20:21:36 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jttt9-0006GH-1s for emacs-devel@gnu.org; Wed, 07 May 2008 20:21:36 -0400 Original-Received: from [199.232.76.173] (port=53409 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jttt8-0006G8-V1 for emacs-devel@gnu.org; Wed, 07 May 2008 20:21:34 -0400 Original-Received: from ntp.math.s.chiba-u.ac.jp ([133.82.132.2]:57745 helo=mathmail.math.s.chiba-u.ac.jp) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Jttt8-0004Ks-7v for emacs-devel@gnu.org; Wed, 07 May 2008 20:21:34 -0400 Original-Received: from church.math.s.chiba-u.ac.jp (church [133.82.132.36]) by mathmail.math.s.chiba-u.ac.jp (Postfix) with ESMTP id 0BCF12C40; Thu, 8 May 2008 09:21:31 +0900 (JST) In-Reply-To: <200805070715.m477FqOT010542@sallyv1.ics.uci.edu> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.6 Emacs/23.0.50 (sparc-sun-solaris2.8) MULE/5.0 (SAKAKI) X-detected-kernel: by monty-python.gnu.org: NetBSD 3.0 (DF) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:96715 Archived-At: >>>>> On Wed, 07 May 2008 00:15:52 -0700, Dan Nicolaescu said: > YAMAMOTO Mitsuharu writes: >> >>>>> On Tue, 06 May 2008 22:55:12 -0700, Dan Nicolaescu >> said: >> >> >> The bug introduced by this change is mentioned here: >> >> http://lists.gnu.org/archive/html/emacs-devel/2007-12/msg01069.html >> >> > OK, a 1 line change (in a ~1000 lines patch) that you seemed to >> have > known about for a while. >> >> 1-line change can introduce a nasty bug as actually seen in this >> case. And this could be easily avoided by not changing the part >> that is unrelated to multi-tty. > And it would have been easily fixed, like all other bugs in emacs, > had the platform not been declared unmaintained the moment the patch > came out. Not saying that without the patch the code would not even > compile. Not mentioning that you could have simply fixed it without > causing all this racket. Again, I'm saying about mixing unrelated changes, not this particular single-line bug. Please don't understate the problem. And about this ChangeLog entry: 2008-05-07 Dan Nicolaescu * macfns.c (Fx_create_frame): Make a copy of frame parameters because the original parameters are in pure storage now. The primary purpose of the copying is not for the parameters allocated in the pure storage, but to prepare for frame parameter clearing in x_get_arg. Lisp_Object x_get_arg (dpyinfo, alist, param, attribute, class, type) Display_Info *dpyinfo; Lisp_Object alist, param; char *attribute; char *class; enum resource_types type; { register Lisp_Object tem; tem = Fassq (param, alist); if (!NILP (tem)) { /* If we find this parm in ALIST, clear it out so that it won't be "left over" at the end. */ #ifndef WINDOWSNT /* w32fns.c has not yet been changed to cope with this. */ Lisp_Object tail; XSETCAR (tem, Qnil); /* In case the parameter appears more than once in the alist, clear it out. */ for (tail = alist; CONSP (tail); tail = XCDR (tail)) if (CONSP (XCAR (tail)) && EQ (XCAR (XCAR (tail)), param)) XSETCAR (XCAR (tail), Qnil); #endif } YAMAMOTO Mitsuharu mituharu@math.s.chiba-u.ac.jp